ggerganov / ggml

Tensor library for machine learning
MIT License
11.25k stars 1.05k forks source link

fix(metal) : offset integer overflows #1015

Closed pminev closed 4 days ago

pminev commented 6 days ago

-- While running StableDiffusion.cpp locally with Metal some offsets overflow and results in incorrect calculations

There are tests in test-backend-ops.cpp for im2col which are too big and are taking a long time, so they are commented for now, but can be used for testing the overflow.

ggerganov commented 4 days ago

Need to rebase on latest master and we can merge.