search

ggerganov / ggml

Tensor library for machine learning
MIT License
11.22k stars 1.04k forks source link

Support MLIR #189

Open theoparis opened 1 year ago

theoparis commented 1 year ago

I would love to see MLIR support. MLIR implements a vulkan runner built in as well as a SPIRV cpu runner. It seems like it was up-voted but I don't see any discussion on why CUDA or OpenCL was added to this project instead.

If it is needed, it could be a separate project wrapping ggml instead of adding support directly in ggml.

See https://github.com/ggerganov/llama.cpp/discussions/915#discussioncomment-5598471 for more information.

theoparis commented 8 months ago

I'm not sure that this is needed now that GGML supports Vulkan directly, but I'll keep this open just in case. Edit: I just got an error with vulkan ggml_vulkan: GGML_OP_MUL_MAT_ID not implemented yet. I guess MLIR is still important