ggerganov / whisper.cpp

Port of OpenAI's Whisper model in C/C++
MIT License
35.54k stars 3.62k forks source link

BUGS: no-gpu not working and more bugs #2364

Open DRomatzki opened 2 months ago

DRomatzki commented 2 months ago

First off. I am not a C programmer but I wanted to use the server.cpp and main.cpp for inference. Both have different commandline arguments and thus difficult to implement. Both do not recognise a boolean command line. If it is specified it is the opposite of the default value. if not then it is the default value.

Talking about inference time. The server.cpp takes double the time as the Main.cpp to infer the same input file., all in the same folder on the same drive. I do not know what to say..... if your plan is to just focus on the library then you are missing something big. You have to standardise the commandline options, add standard values such as allowing values for boolean variables, ensure the server is running as fast as the main.cpp. The "server.cpp" and the main.cpp", in the end, are the software that showcases your library. If they do not work then what confidence does one have in your library? And, BTW, why do you use a single file for your whisper.cpp, server.cpp and main.cpp? why not refactor it so that it is easier to understand and maybe, contribute. I was in the process of writing a frontend and backend for this in Typescrypt, but I made a serious error. I should have tested your code before starting. The backend is 95% finished and the frontend 80%. I am now putting it on ice and maybe focus on other libraries. etc. I am sorry ...... This has still a long way to go.....

Alumniminium commented 2 months ago

Should I use whisper.cpp in my project? whisper.cpp is a hobby project. It does not strive to provide a production ready implementation. The main goals of the implementation is to be educational, minimalistic, portable, hackable and performant. There are no guarantees that the implementation is correct and bug-free and stuff can break at any point in the future. Support and updates will depend mostly on contributions, since with >time I will move on and won't dedicate too much time on the project. If you plan to use whisper.cpp in your own project, keep in mind the above. My advice is to not put all your eggs into the whisper.cpp basket.

taken from the FAQ: https://github.com/ggerganov/whisper.cpp/discussions/126

DRomatzki commented 2 months ago

I do understand that comment, but what about the 380 contributors" It is just .... putting so much effort into this code and then not complete it, would be a waste of time and effort. However, I will accept it. My project was also only a hobby and a contribution to the opensource community, not for production purposes. Since I do not know C++ I will have to implement something else :-) or I learn to hack C++