ggiamarchi / vagrant-openstack-provider

Use Vagrant to manage OpenStack Cloud instances.
MIT License
247 stars 101 forks source link

Upgrade json gem version to latest #268

Closed dandunckelman closed 8 years ago

dandunckelman commented 8 years ago

After further discussion in https://github.com/ggiamarchi/vagrant-openstack-provider/pull/267, I've recreated the PR since I deleted the original fork, derp. The only difference between that PR and this one is that I updated to Ruby v2.2.3, whereas the other PR used v2.2.2.

I wanted to install this plugin with the latest Vagrant (v.1.8.1 when I went to https://www.vagrantup.com/downloads.html) but received errors when bundle tries installing the json gem v1.7.7. So, I figured I'd try getting the install to work with the latest JSON gem.

To do this, I performed the following on an Ubuntu v14.04 VM with Ruby v2.2.3 (via RVM):

Then the install worked as expected. I assume that this would fix the following issues: https://github.com/ggiamarchi/vagrant-openstack-provider/issues/265 & https://github.com/ggiamarchi/vagrant-openstack-provider/issues/266

Should I update .travis.yml to do the following or something similar?

beddari commented 8 years ago

Verified as working on Fedora 23 using the latest vagrantup.com vagrant package and system Ruby to build the updated .gem:

git clone https://github.com/dandunckelman/vagrant-openstack-provider.git
cd vagrant-openstack-provider/source
git checkout upgrade-json-dependency
sudo dnf install ruby-devel redhat-rpm-config
bundle
bundle exec rake build
vagrant plugin install pkg/vagrant-openstack-provider-0.7.0.gem
artem-sidorenko commented 8 years ago

Verified on Ubuntu 14.04 with latest vagrant, works

jhoblitt commented 8 years ago

Confirmed as working with the vagrant-1.8.1-1.x86_64 rpm (vagrantup; not fedora's native packaging) on Fedora 23.

wbean1 commented 8 years ago

+1, encountered same issue trying to use this plugin on Vagrant 1.8.1... thanks for providing the manual plugin build work-around... hope this gets merged.

ggiamarchi commented 8 years ago

LGTM

Sorry guys for the long time to merge the one.

ggiamarchi commented 8 years ago

Included in release 0.7.1

dandunckelman commented 8 years ago

@ggiamarchi thanks!

v1k0d3n commented 8 years ago

@ggiamarchi Thank you for resolving this issue!!

jhoblitt commented 8 years ago

@ggiamarchi Thank you! :clap: