ggiamarchi / vagrant-openstack-provider

Use Vagrant to manage OpenStack Cloud instances.
MIT License
247 stars 101 forks source link

vagrant status and global-status commands use active instead of running to describe state #287

Open jmatt opened 8 years ago

jmatt commented 8 years ago

When running vagrant status and vagrant global-status commands, this plugin uses active to describe what Vagrant typically calls running state. I believe active is correct from an OpenStack perspective though.

Vagrant status example:

⇝ vagrant status
Current machine states:

p-es-1                    active (openstack)

This environment represents multiple VMs. The VMs are all listed
above with their current state. For more information about a specific
VM, run `vagrant status NAME`.

Vagrant global-status example:

⇝ vagrant global-status
id       name          provider   state     directory
----------------------------------------------------------------------------------------------------------
4c361b5  el7           aws        running   /Users/jmatt/dev/...
bb1ffa0  default       virtualbox running   /Users/jmatt/dev/...
72227c0  elasticsearch openstack  active    /Users/jmatt/dev/...
0eca49c  default       virtualbox running   /Users/jmatt/dev/...

So the question is, should this plugin follow OpenStack or Vagrant conventions. From my perspective I think it should follow Vagrant conventions. It would require only a change to the strings used in when creating status descriptions. So the change is small. But it may well be a breaking change to any tools that were already built and expect active. If the community is interested in changing to running, I'd be glad to PR it.

ggiamarchi commented 8 years ago

@jmatt Thank you for this report. I agree with you, the Vagrant standard should be used. Even if this is a breaking change, i think we should do this. It won't be a huge work for anyone. Feel free to submit a PR.