ggiamarchi / vagrant-openstack-provider

Use Vagrant to manage OpenStack Cloud instances.
MIT License
247 stars 101 forks source link

rsync excludes cannot be overridden #291

Closed ghost closed 7 years ago

ghost commented 8 years ago

When using rsync as the sync_method, exclude rules related to version control are hard-coded and I am not provided an option to change this. In particular the --cvs-exclude option excludes any folder named 'tags', which my java application requires to run.

In my opinion, a better design decision would be to remove the default exclude rules entirely. Any user who desires exclude rules can specify them in the Vagrantfile. For my purposes being able to specify 'no excludes' would also be sufficient, as would removing the --cvs-exclude option from https://github.com/ggiamarchi/vagrant-openstack-provider/blob/master/source/lib/vagrant-openstack-provider/action/sync_folders.rb#L99 .

Steps to reproduce:

Expected behavior: Files that I do not specifically exclude should be present in /vagrant

Actual behavior: Any files that match the rsync-exclude ruleset (among others) are absent from /vagrant

ghost commented 8 years ago

I have also attempted to work around this by setting rsync_includes to 'tags' or '*' but unfortunately this does not override the rsync exclude command line options.

ghost commented 8 years ago

https://github.com/ggiamarchi/vagrant-openstack-provider/pull/292

ggiamarchi commented 7 years ago

The provider has moved to the standard vagrant synced folders middleware. I close all issues related to the legacy synced folders implementation. Feel free to comment/reopen this thread if you think you still get an issue related to this provider.