search

ggiamarchi / vagrant-openstack-provider

Use Vagrant to manage OpenStack Cloud instances.
MIT License
247 stars 101 forks source link

Fix/master/rsync excludes too broad #292

Closed ghost closed 7 years ago

ghost commented 8 years ago

This will change the default behavior of sync_folders, and the documentation has been updated accordingly.

A less impactful change would have been possible by fixing rsync_includes, however that will be complicated because of the underlying behavior of rsync, and it seems in this case that the simpler option is the better design choice.

The new boolean option rsync_cvs_excludes has been added to the provider in case --cvs-excludes is required for someone's workflow.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.7%) to 92.362% when pulling 0a4807cd15627a6fc4a49ad009c84bb939047eb2 on aaronboyle:fix/master/rsync-excludes-too-broad into 466ac027120464a49b106f2da50f544f9a33cc7a on ggiamarchi:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.7%) to 92.362% when pulling 0a4807cd15627a6fc4a49ad009c84bb939047eb2 on aaronboyle:fix/master/rsync-excludes-too-broad into 466ac027120464a49b106f2da50f544f9a33cc7a on ggiamarchi:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.5%) to 92.075% when pulling a35bb5fb75d0003e88049ce29df270177d969cac on aaronboyle:fix/master/rsync-excludes-too-broad into 466ac027120464a49b106f2da50f544f9a33cc7a on ggiamarchi:master.

ghost commented 8 years ago

Reopened pull request after adding boolean option rsync_cvs_excludes

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.8%) to 92.378% when pulling 0e1305385f7a8b976a83ab0d580fe171467a77bb on aaronboyle:fix/master/rsync-excludes-too-broad into 466ac027120464a49b106f2da50f544f9a33cc7a on ggiamarchi:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.8%) to 92.378% when pulling 0e1305385f7a8b976a83ab0d580fe171467a77bb on aaronboyle:fix/master/rsync-excludes-too-broad into 466ac027120464a49b106f2da50f544f9a33cc7a on ggiamarchi:master.

ghost commented 8 years ago

The CI failure above appears to be a toolchain problem, only present when building for vagrant 1.6.5.:

Gem::InstallError: rack requires Ruby version >= 2.2.2. An error occurred while installing rack (2.0.1), and Bundler cannot continue. Make sure that gem install rack -v '2.0.1' succeeds before bundling. The command "bundle 1.6.6 install --without debug" failed. Retrying, 2 of 3.

ggiamarchi commented 7 years ago

@aaronboyle The provider has moved now to the standard vagrant synced folders middleware. The legacy rsync middleware within this provider is still available for now (use_legacy_synced_folders = true) but will be removed in a further release. By the way, the legacy implementation is no longer maintained. Thanks for your contribution.