Switch to Vagrant SyncedFolders

ggiamarchi / vagrant-openstack-provider

Use Vagrant to manage OpenStack Cloud instances.

MIT License

247 stars 101 forks source link

Switch to Vagrant SyncedFolders #295

Closed Sharpie closed 7 years ago

Sharpie commented 8 years ago

Vagrant 1.5 introduced a standard SyncedFolders middleware which can be re-used by providers to implement things such as rsync support. This patch uses Vagrant SyncedFolders as the default sync implementation instead of the legacy SyncFolder implementation inherited from the Rackspace project.

The legacy implementation is retained for backwards compatibility and will be used if any of the following provider options is set:

rsync_includes
rsync_ignore_files
sync_method

A deprecation warning will be printed.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 91.396% when pulling e01ef2e106e8433c9717efa7cb6bc6d78e4a105a on Sharpie:use-standard-synced-folders into eb068092706871156893b539b1828f60d764c837 on ggiamarchi:master.

coveralls commented 8 years ago

Coverage decreased (-0.2%) to 91.396% when pulling 2fb940d32a4c48c6f43bc3031c8fdab52675e3c6 on Sharpie:use-standard-synced-folders into eb068092706871156893b539b1828f60d764c837 on ggiamarchi:master.

Sharpie commented 8 years ago

@ggiamarchi Thoughts on this change? The built-in synced folder implementation has many more features, and supports nice things like auto-installation of rsync. It also allows multiple synced folders to be set up, allows a single set of exclusions to be used across multiple providers, and allows for alternate sync methods such as NFS.

ggiamarchi commented 8 years ago

@Sharpie No worries, I definitely agree moving to the built-in synced folder implementation is a thing to do ! Furthermore, there's a few issues and PR opened regarding synced folders on the OpenStack provider and i guess moving to the built-in implementation will resolve most of them. I'll try to take time soon to test and review.

By the way, if someone else wants to help testing and feedback about about this one it would be really valuable.

@craigtracey, @aaronboyle, @brijs you could be interested in this one.

ggiamarchi commented 7 years ago

@Sharpie Thanks for this great contribution and sorry for the long time to merge !

Sharpie commented 7 years ago

No worries! The FOSS projects I manage tend to have similar review lengths :)

Thanks for the merge!