Add snapshot support - Githubissues

ggiamarchi / vagrant-openstack-provider

Use Vagrant to manage OpenStack Cloud instances.

MIT License

247 stars 101 forks source link

Add snapshot support #296

Closed Sharpie closed 7 years ago

Sharpie commented 8 years ago

This patchset adds provider actions required by the vagrant snapshot command introduced in Vagrant 1.8.0. The semantics of each action are modeled after the Virtualbox implementation:

https://github.com/mitchellh/vagrant/blob/v1.8.0/plugins/providers/virtualbox/action.rb#L230-L281

The actions make use of Vagrant UI strings introduced in 1.8.0 and are thus surrounded by guard statements to prevent them from being loaded by older Vagrant versions.

coveralls commented 8 years ago

Coverage decreased (-3.9%) to 87.685% when pulling 63390204b30c5fb99a838852d8f8ab8ebde29ddd on Sharpie:add-snapshot-support into eb068092706871156893b539b1828f60d764c837 on ggiamarchi:master.

coveralls commented 8 years ago

Coverage decreased (-4.3%) to 87.362% when pulling 83dee1709ec98b7eb6226f6224801d9ec1581630 on Sharpie:add-snapshot-support into eb068092706871156893b539b1828f60d764c837 on ggiamarchi:master.

coveralls commented 8 years ago

Coverage decreased (-3.8%) to 87.788% when pulling 599cf79d4e32cda016c9c99da265a37c43604f7b on Sharpie:add-snapshot-support into 569a7b81f85bea8ca9c7546ef2238b07edda6566 on ggiamarchi:master.

npwalker commented 7 years ago

This is great, I'd love to see this merged!

Sharpie commented 7 years ago

@ggiamarchi I've updated this patchset to correct the metadata issue and have been running it successfully against OpenStack Mitaka for a couple weeks now.

coveralls commented 7 years ago

Coverage decreased (-3.6%) to 87.6% when pulling 12ab90667de32c7e04ea2f2501c501a3c75b4579 on Sharpie:add-snapshot-support into 876ad73d4af37365f3db0faccf8a8ba750dca7b8 on ggiamarchi:master.

npwalker commented 7 years ago

@ggiamarchi I created my own gem with @Sharpie's changes and I'm using it successfully. Is there anything preventing a merge?