ggiamarchi / vagrant-openstack-provider

Use Vagrant to manage OpenStack Cloud instances.
MIT License
245 stars 102 forks source link

add identity version 3 keystone login #307

Closed Tha-Robert closed 7 years ago

Tha-Robert commented 7 years ago

As stated in the header adding support for using v3 of keystone.

Added this configs to match env from openstack: os.project_name = ENV['OS_PROJECT_NAME'] os.domain_name = ENV['OS_USER_DOMAIN_NAME'] os.identity_api_version = ENV['OS_IDENTITY_API_VERSION'] os.interface_type = "public"

identity_api_version is the default 2 if not set. os.project_name is the old tenant name, but it changed name in the env so i did not want to reuse it. Did the same with interface and endpoint.

Fixed #4

Signed-off-by: Robert Marklund robert.marklund@ericsson.com

Tha-Robert commented 7 years ago

Please review so I can fix all at once.

/R

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-4.2%) to 87.47% when pulling b1e5c68f105b3bbba8cc39472d81ec43ece10ce0 on Tha-Robert:master into 4a252918e7ebbed0db5562dd8f671bccadde586e on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-4.2%) to 87.47% when pulling 426b9c9082c37dd4bb39956e05ae421438765a4d on Tha-Robert:master into 4a252918e7ebbed0db5562dd8f671bccadde586e on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-2.2%) to 89.398% when pulling 19bab0d6e08abd56722a565a8a8d71ef3d372099 on Tha-Robert:master into 4a252918e7ebbed0db5562dd8f671bccadde586e on ggiamarchi:master.

Tha-Robert commented 7 years ago

Project dead ?

/R

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 91.522% when pulling 21a8963171f87aa7210f0c65c8678a88a12e5ca4 on Tha-Robert:master into 4a252918e7ebbed0db5562dd8f671bccadde586e on ggiamarchi:master.

ggiamarchi commented 7 years ago

Hi @Tha-Robert, the project is not dead at all even if it currently moves slowly. By the way, supporting Keystone v3 is a major concern, probably the most important in progress pull-request for now. I will start the review soon.

Tha-Robert commented 7 years ago

I tied to fix all of them, and also added the vagrant_openstack.config.invalid_api_version message.

Please have a look.

/R

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 91.248% when pulling 3635708301954dff3c2387beafa78bfa3e332b9b on Tha-Robert:master into ced92d22e82bd62d24271eacc2cb4bb3d0ef6002 on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 91.248% when pulling 3635708301954dff3c2387beafa78bfa3e332b9b on Tha-Robert:master into ced92d22e82bd62d24271eacc2cb4bb3d0ef6002 on ggiamarchi:master.

Tha-Robert commented 7 years ago

The check(travisCI) have false positives. So it actually passes :)

/R

ggiamarchi commented 7 years ago

@Tha-Robert Yes, that was an issue on the travis infrastructure during your build. I reran the job and it went well. Thank you for this contribution. Good work 👍