ggiamarchi / vagrant-openstack-provider

Use Vagrant to manage OpenStack Cloud instances.
MIT License
245 stars 102 forks source link

Respect config.ssh.insert_key #328

Closed akitada closed 7 years ago

akitada commented 7 years ago

Skip generating a keypair when config.ssh.insert_key is false.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 87.483% when pulling 1206c16944f442b00fba7a938d203634a67234c3 on akitada:respect-insert-key into 34cb4cb8467b7af26775c5dc657850a756209133 on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 87.617% when pulling 47887c9e6fc06df2c6dccbb85bb647dd7b99857e on akitada:respect-insert-key into 34cb4cb8467b7af26775c5dc657850a756209133 on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 87.617% when pulling f133db64a8789b0dfdd0cdf964160cee0466ef5b on akitada:respect-insert-key into 34cb4cb8467b7af26775c5dc657850a756209133 on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.02%) to 87.617% when pulling 3959594152252da1d7266fd4ff46cdae912626d7 on akitada:respect-insert-key into 34cb4cb8467b7af26775c5dc657850a756209133 on ggiamarchi:master.

akitada commented 7 years ago

@ggiamarchi @julienvey This patch completes https://github.com/ggiamarchi/vagrant-openstack-provider/issues/54. I would appreciate your review.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.5%) to 87.094% when pulling 76558bb410e6b0ff61b888b7a7c4d15a3a8c079e on akitada:respect-insert-key into 34cb4cb8467b7af26775c5dc657850a756209133 on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.3%) to 87.272% when pulling 6d43d9fb3227fc8203d1444b954ae0753b18c204 on akitada:respect-insert-key into 34cb4cb8467b7af26775c5dc657850a756209133 on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 87.628% when pulling 7a73359b246f66a5a492f194e108b710e4853246 on akitada:respect-insert-key into 34cb4cb8467b7af26775c5dc657850a756209133 on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 87.628% when pulling e4709cfc6944c5e9d391cf6f61d17b46175f9a00 on akitada:respect-insert-key into 34cb4cb8467b7af26775c5dc657850a756209133 on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.7%) to 86.356% when pulling e0543b10f0a2c714f2a959a51753a477a6a944cd on akitada:respect-insert-key into 2978da1368f8306d4516aa4c614bd290056a349f on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.7%) to 86.356% when pulling c778e0847adf8a2181240677be5782c38b37724b on akitada:respect-insert-key into 2978da1368f8306d4516aa4c614bd290056a349f on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 87.06% when pulling e4fa083ba8257f2f1a3b35a4c4fb8607f6be931e on akitada:respect-insert-key into 2978da1368f8306d4516aa4c614bd290056a349f on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.02%) to 87.016% when pulling 692b84501eb79f4ca917abb26c869aa6bca5e30d on akitada:respect-insert-key into 2978da1368f8306d4516aa4c614bd290056a349f on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 87.06% when pulling 692b84501eb79f4ca917abb26c869aa6bca5e30d on akitada:respect-insert-key into 2978da1368f8306d4516aa4c614bd290056a349f on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 87.06% when pulling 692b84501eb79f4ca917abb26c869aa6bca5e30d on akitada:respect-insert-key into 2978da1368f8306d4516aa4c614bd290056a349f on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 87.06% when pulling 692b84501eb79f4ca917abb26c869aa6bca5e30d on akitada:respect-insert-key into 2978da1368f8306d4516aa4c614bd290056a349f on ggiamarchi:master.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.03%) to 87.06% when pulling 09e04f344296e6efc582973a69469a265bba11b9 on akitada:respect-insert-key into 2978da1368f8306d4516aa4c614bd290056a349f on ggiamarchi:master.

akitada commented 7 years ago

Sorry for noise. The patch is ready for review this time.

ggiamarchi commented 7 years ago

@akitada No problem at all! At a first sight, it looks to be a good job. I'll test and review soon.

ggiamarchi commented 7 years ago

@akitada Good one!