search

ggiamarchi / vagrant-openstack-provider

Use Vagrant to manage OpenStack Cloud instances.
MIT License
245 stars 102 forks source link

Discover URLs instead of constructing in neutron #343

Closed akosiaris closed 1 year ago

akosiaris commented 6 years ago

The approach of constructing URLs via string concatenation is brittle and breaks with projects implementing the openstack API but advertising URLs with trailing slash. In that case URLs contains two consecutives slashes ending up in the plugin not working. Instead, discover the required URLs by parsing the top level response and choosing the URL to use

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.7%) to 86.389% when pulling 924aab86ebf3fca0bf095474004e0396b51d15e8 on akosiaris:neutron_discover_urls into 11e7cadc58202604555f4a5e78fcd362a31d7df5 on ggiamarchi:master.

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.7%) to 86.389% when pulling dfec9c87de9cdb0224798f64a901f67f81fb92a7 on akosiaris:neutron_discover_urls into 11e7cadc58202604555f4a5e78fcd362a31d7df5 on ggiamarchi:master.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.06%) to 87.145% when pulling 55347ab9e4a033939893602f035aba804ca84457 on akosiaris:neutron_discover_urls into 11e7cadc58202604555f4a5e78fcd362a31d7df5 on ggiamarchi:master.

akosiaris commented 6 years ago

I 've fixed the travis errors that were related to this change, I don't think it's the place of this patch to fix fix ruby version 2.0.0 with vagrant 1.6 and 1.7 checks as those fail due to

Gem::InstallError: public_suffix requires Ruby version >= 2.1.

@ggiamarchi Would you like to review this ? Thanks

akosiaris commented 1 year ago

I just realized I left this hanging for years. I am sorry. I 'll close the PR as is