Rip out version checks - Githubissues

ekohl commented 6 years ago

I realize this is a partial fix that's unlikely to be accepted, but let me make the case and we can see where we can end up. These version checks are highly annoying for multiple reasons.

They require internet access on every command. This is a privacy concern because it leaks when you're using vagrant. It's also not guaranteed to be available.
They print warnings to stdout which breaks commands like vagrant ssh-config
There is no way to deactivate them. I know I installed a custom version because I needed fixes not available in a released version.

coveralls commented 6 years ago

Coverage remained the same at 87.74% when pulling a9d9c46f22e5675c3ec95d797e2b18d1b48cf4ab on ekohl:remove-version-checks into 4ee2d594e9d98968c9ea44c0cdc7e864eff5f45b on ggiamarchi:master.

ggiamarchi commented 5 years ago

@ekohl As you expected, this PR won't be accepted but I agree this is a real issue.

A fix is provided by #365

ggiamarchi / vagrant-openstack-provider

Rip out version checks #358