search

ggloor / ALDEx_bioc

ALDEx_bioc is the working directory for updating bioconductor
27 stars 13 forks source link

pass aldex.glm.effect args to aldex.effect #49

Closed pooranis closed 2 years ago

pooranis commented 2 years ago

Hi, thank you for this really nice package.

I noticed that the parameters for aldex.glm.effect are not being passed to aldex.effect. Is there a downside to passing those args? If not, I have done it here in this pull request.

One question: This function iterates over the columns of clr@conds. If include.sample.summary is TRUE, will the median clr values for each sample returned by aldex.effect be the same for each iteration?

ggloor commented 2 years ago

Thanks for this. Oversight on my part.

Yes, the median values for each sample should be the same because they are calculated from the same set of MC.instances. The effect, relative abundance per group, difference, effect and overlap will differ