ggloor / ALDEx_bioc

ALDEx_bioc is the working directory for updating bioconductor
27 stars 13 forks source link

ALDEx2 new version (1.32.0) output effect size difference from (1.28.1) #67

Open davis-rudolfs opened 1 year ago

davis-rudolfs commented 1 year ago

Description

I have noticed a significant difference in the number of ZOTUs with effect sizes greater than 1 between ALDEx2 version 1.28 and version 1.32. Unfortunately I have not found information what has changed between these two versions. However, in version 1.28.1, I observed 8 ZOTUs with an effect size greater than 1, but in version 1.32.0, this number has increased to 20 (see pictures).

Expected Behavior and main question

I would like to understand what changes were made in version 1.32 that could account for this difference in results. Can you please provide some insights into the modifications made to the algorithm or any other factors that might explain this variation? How should I better approach further analysis?

Steps to Reproduce the Issue

  1. Load sample data (in this case phyloseq object, same individuals, 2 separate visits).
  2. Perform the ALDEx2 analysis (version 1.28.1), Bioconductor version 3.15, R version 4.2.1
  3. Load R version 4.3.1, update Bioconductor to 3.17, do not change any of the previous code and perform ALDEx2 analysis (now the version should be 1.32.0)
  4. Observe the difference in the number of ZOTUs with effect sizes greater than |1|.

Additional Information

Aldex-1-28-group5-effect Aldex-1-28-group5

Aldex-1-32-group5-effect Aldex-1-32-group5

ggloor commented 1 year ago

Without seeing your code, I suspect that it is the calculation of effect size that has changed. The newest version that you are using is calculating paired effect size properly (i.e., the mean effect size of differences in effect on a paired-sample basis) rather than in bulk (i.e., the mean effect size with samples unpaired). This usually causes effect sizes to increase a little bit.

I see that roughly the same number of features have a significant adjusted p-value.

You could test this by running aldex.clr(), then aldex.effect( paired=T or F) and seeing if this addresses your issue

davis-rudolfs commented 1 year ago

Thank you for your time and the quick response!

The number of significant features did not change, that is correct. I have checked that the difference between both ALDEx2 versions and only when aldex.effect paired= T there is a difference. Thank you for clarifying.

I was considering mentioning all features with the effect size > |1| in my manuscript, but I think I will use the p-value as a cut off for the main findings.