search

ggobi / ggally

R package that extends ggplot2
http://ggobi.github.io/ggally/
588 stars 118 forks source link

chore: Use lifecycle for arguments deprecation in ggpairs #494

Closed 92amartins closed 6 months ago

92amartins commented 7 months ago

This aims to partially fix #365.

It only deprecates arguments in the ggpairs.

If desired I can follow up with deprecation warnings for the other files that have functions deprecated functions/arguments:

schloerke commented 7 months ago

If desired I can follow up with deprecation warnings for the other files that have functions deprecated functions/arguments:

  • deprecated.R
  • gg-plots.R
  • gg_matrix_gtable.R
  • ggnet.R

Yes, please! Thank you

92amartins commented 6 months ago

If desired I can follow up with deprecation warnings for the other files that have functions deprecated functions/arguments:

  • deprecated.R
  • gg-plots.R
  • gg_matrix_gtable.R
  • ggnet.R

Yes, please! Thank you

I'm thinking about breaking down these changes in maybe 2 or 3 PR's, what do you think?

schloerke commented 6 months ago

I'm thinking about breaking down these changes in maybe 2 or 3 PR's, what do you think?

Let's get this PR merged in so that your GHA runs will happen automatically. If it's all in the same idea... let's do it in a single followup PR.

schloerke commented 6 months ago

Merging

The two ubuntu errors are due to install failures from a dep package for {emmeans} unrelated to this PR. (Happens on master branch.)