search

ggp-org / ggp-base

The General Game Playing Base Package
115 stars 153 forks source link

Local game repository drops games with spaces in their names #16

Closed samschreiber closed 10 years ago

samschreiber commented 11 years ago

"When you select the Local Game Repository, any games in folders that have a space in the folder name are not shown and therefore cannot be selected."

samschreiber commented 10 years ago

Game keys shouldn't include spaces; they should be simple alphanumeric identifiers (e.g. "connectFour"). Game names, with proper punctuation and spacing, should be specified as the "gameName" field in the game metadata file, and used when displaying game names to the user.

I've added better checks for this in https://github.com/ggp-org/ggp-base/commit/14dd854c4c7fd5eb368b21b4b40df569e791ae87 so that these games are silently dropped, rather than resulting in exceptions being thrown.