search

ggp-org / ggp-repository

GGP Game Repository
6 stars 5 forks source link

Fix broken visualizations #54

Open AlexLandau opened 8 years ago

AlexLandau commented 8 years ago

Taking a pass through some of the more recent games to check what needs to be fixed (checking Firefox and Chrome only):

Mad Bishops: fails on Firefox and Chrome Queens puzzle games: fail on Firefox Futoshiki games: fail on Firefox Rubik's Cube: fails on Firefox

AlexLandau commented 7 years ago

The Atari Go and Gomoku games also fail on Firefox. Shogi was partly working before (the "switch pieces" button did not work) but the .svg loading seems to be broken again. When I download a "lance.svg" file, it has a fragment from earlier in the file repeated at the end, which breaks XML validation (this may be an issue with a different repo).

AlexLandau commented 7 years ago

The Mad Bishops game works on both browsers after https://github.com/ggp-org/ggp-repository/pull/57

AlexLandau commented 7 years ago

I've been trying some of these games with my own visualization frontend with a different implementation from Tiltyard's. All of these visualizations (except for Shogi, which appears to have server-side problems) work on Firefox in that case.

AlexLandau commented 7 years ago

Actually, I'm doing the same basic steps to do the XSLT processing that Tiltyard does (minus setting the height and width), so there may be some more obscure problem with Tiltyard's visualizations (e.g. how they are being grafted into the page).