search

ggrandou / abootimg

Tool to read/write/update android boot images
GNU General Public License v2.0
121 stars 43 forks source link

abootimg: Improve compatability with no-initrd abootimg configs #3

Open johnstultz-work opened 6 years ago

johnstultz-work commented 6 years ago

With newer AOSP devices, system can be used as rootfs, resulting in no initrd being used in the bootimg.

Without this patch, 'abootimg -x' on such an image would result with: /home/jstultz/noinitrd-boot.img: ramdisk size is null /home/jstultz/noinitrd-boot.img: not a valid Android Boot Image.

This patch just avoids failing out when we see a null ramdisk size.

Signed-off-by: John Stultz john.stultz@linaro.org

temoto commented 5 years ago

This patch is required to work with stock OrangePi images. Please merge.

lag-linaro commented 5 years ago

Could someone merge this PR please?

It fixes a severe issue when working with current Android images.

LGTM - +1

phhusson commented 5 years ago

"someone". You do realize this is a one-people project they do (well did it looks like) on their free time? And there has been no commit since 2012 just saying "please merge" will probably not cut it.

I understand your corporate want this, I think you can feel free to fork it and maintain it.

Also "current Android images" doesn't need this because of Android Q's first-stage init.

If I'm not mistaken, this is required exclusively on Android Pie devices running system-as-root without A/B slots.

lag-linaro commented 5 years ago

"someone". You do realize this is a one-people project they do (well did it looks like) on their free time?

Yes.

And there has been no commit since 2012 just saying "please merge" will probably not cut it.

I see that. It doesn't mean they won't take a few minutes out of their time to press "merge".

I understand your corporate want this, I think you can feel free to fork it and maintain it.

This doesn't have anything to do with "my corporate".

Also "current Android images" doesn't need this because of Android Q's first-stage init.

If I'm not mistaken, this is required exclusively on Android Pie devices running system-as-root without A/B slots.

Okay, good to know. It's still required for certain use-cases though.