search

ggrecow / SQAT

SQAT is an open-source repository of MATLAB codes containing the implementation of key metrics for quantitative sound quality analysis.
Other
40 stars 13 forks source link

Gen_weighting_filters.m small change 'i' to '1i' on line 44. Also, th… #1

Closed talesstorani closed 1 year ago

talesstorani commented 1 year ago

Hello Gil, Congrats on this toolbox! Was using the sound level meter to compare. It was noticed the and extra order for the B weighting filter. If you agree to this tiny change I am kindly sending a pull request from the change.

Thanks!

Abraço!

uglyrocks commented 1 year ago

@talesstorani: thank you for the contribution. Please next time provide some scientific motivation to the change, like: "the frequency response seems off" or "the filter coefficients don't match the IEC coefficients" or, simply, sharing a script where the "bug" is visible. Otherwise it makes it more difficult for us, as developers, to confirm that what you say is indeed correct. In the toolbox we have been working hard on keeping a hard backward compatibility with all our functions (to ensure reproducibility) and, therefore, we invest a lot of time in every change to existing function.

ggrecow commented 1 year ago

Hi @talesstorani, many thanks for your contribution.

After carefully checking, we noted that indeed the B-weighting ponderation was not correct. @uglyrocks just included now in the toolbox the "test_Gen_weighting.m" code, which plots all the frequency ponderation curves for a quick check. Now the B-weighting curve looks better with the changes you proposed.

However we cant really tell much about how this implementation compares with other measurement systems because currently we dont have a validation code for the sound_level_meter. It would be very helpful if you could share your comparison study so we can include it as a validation of the sound_level_meter implementation in the toolbox.

Cheers, Gil.