search

ggreen86 / XLSX-Workbook-Class

VFP Class to Create an XLSX Workbook without Excel Automation or Installed
45 stars 16 forks source link

RelType = "customXML" hits SET STEP ON #83

Open pivoten-psherwood opened 1 year ago

pivoten-psherwood commented 1 year ago

I have a sheet that hits the SET STEP ON because it has a relType of customXML.

Is there a fix for this yet? Not sure why this sheet has that. Running an older version of XLSX-Workbook-Class works.

ggreen86 commented 1 year ago

Hello—

Can you provide me a sample of the xlxs file that I can debug with? Thank you.

Greg

From: pivoten-psherwood @.> Sent: Sunday, April 2, 2023 5:31 PM To: ggreen86/XLSX-Workbook-Class @.> Cc: Subscribed @.***> Subject: [ggreen86/XLSX-Workbook-Class] RelType = "customXML" hits SET STEP ON (Issue #83)

I have a sheet that hits the SET STEP ON because it has a relType of customXML.

Is there a fix for this yet? Not sure why this sheet has that. Running an older version of XLSX-Workbook-Class works.

— Reply to this email directly, view it on GitHubhttps://github.com/ggreen86/XLSX-Workbook-Class/issues/83, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGWB33OFIDR4PHF5X7HCUUTW7HVZBANCNFSM6AAAAAAWQRJJLY. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

pivoten-psherwood commented 1 year ago

I've attached the XLSX file that this happens when reading.

Phil

On Mon, Apr 3, 2023 at 2:10 PM ggreen86 @.***> wrote:

Hello—

Can you provide me a sample of the xlxs file that I can debug with? Thank you.

Greg

From: pivoten-psherwood @.> Sent: Sunday, April 2, 2023 5:31 PM To: ggreen86/XLSX-Workbook-Class @.> Cc: Subscribed @.***> Subject: [ggreen86/XLSX-Workbook-Class] RelType = "customXML" hits SET STEP ON (Issue #83)

I have a sheet that hits the SET STEP ON because it has a relType of customXML.

Is there a fix for this yet? Not sure why this sheet has that. Running an older version of XLSX-Workbook-Class works.

— Reply to this email directly, view it on GitHub< https://github.com/ggreen86/XLSX-Workbook-Class/issues/83>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AGWB33OFIDR4PHF5X7HCUUTW7HVZBANCNFSM6AAAAAAWQRJJLY>.

You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>

— Reply to this email directly, view it on GitHub https://github.com/ggreen86/XLSX-Workbook-Class/issues/83#issuecomment-1494761225, or unsubscribe https://github.com/notifications/unsubscribe-auth/A33NFHLWVZVULJNSF3JMORDW7MG7TANCNFSM6AAAAAAWQRJJLY . You are receiving this because you authored the thread.Message ID: @.***>

pivoten-psherwood commented 1 year ago

ASPIRE_03.2023_01.2023 pp.xlsx

ggreen86 commented 1 year ago

Thank you for the sample file. You have a number of 'extra' files that are being added to the xlsx file (probably by Excel) that looks like they are for SharePoint or OneDrive support. I had commented out the handling of these non-standard files in the OpenXlsxWorkbook() method as I have not fully tested the adding of these to the xl_* cursor definitions. I will look into including these files at some point in the future.

For now, these files are excluded when the spreadsheet is resaved. Note: the SET STEP ON does not execute in the run-time environment of VFP (it only executes in the dev-time environment).

pivoten-psherwood commented 1 year ago

Thanks!

The SET STEP ON gets an error in the runtime environment and doesn't import anything.

On Mon, Apr 3, 2023 at 4:20 PM ggreen86 @.***> wrote:

Thank you for the sample file. You have a number of 'extra' files that are being added to the xlsx file (probably by Excel) that looks like they are for SharePoint or OneDrive support. I had commented out the handling of these non-standard files in the OpenXlsxWorkbook() method as I have not fully tested the adding of these to the xl_* cursor definitions. I will look into including these files at some point in the future.

For now, these files are excluded when the spreadsheet is resaved. Note: the SET STEP ON does not execute in the run-time environment of VFP (it only executes in the dev-time environment).

— Reply to this email directly, view it on GitHub https://github.com/ggreen86/XLSX-Workbook-Class/issues/83#issuecomment-1494927718, or unsubscribe https://github.com/notifications/unsubscribe-auth/A33NFHIH3V6V45VWLEL365TW7MWKBANCNFSM6AAAAAAWQRJJLY . You are receiving this because you authored the thread.Message ID: @.***>

ggreen86 commented 1 year ago

I just tried to open and then save to a new xlsx file name. I successfully opened the file (without the custom types) and then saved to a new file name. Attached is the file that I saved.

ASPIRE_03.2023_01.2023.xlsx

pivoten-psherwood commented 1 year ago

I was able to do the same. This came from a client so I'm not sure of the workaround. Since I don't know what is adding these extra files I don't know how to tell them to correct it. Can the OpenXLSXWorkbook method just ignore these?

ggreen86 commented 1 year ago

The class is ignoring those extra files and not including them. You can comment out the SET STEP ON after the OTHERWISE statement if you want to just to be sure it does not stop there.

From: pivoten-psherwood @.> Sent: Tuesday, April 4, 2023 12:00 PM To: ggreen86/XLSX-Workbook-Class @.> Cc: ggreen86 @.>; State change @.> Subject: Re: [ggreen86/XLSX-Workbook-Class] RelType = "customXML" hits SET STEP ON (Issue #83)

I was able to do the same. This came from a client so I'm not sure of the workaround. Since I don't know what is adding these extra files I don't know how to tell them to correct it. Can the OpenXLSXWorkbook method just ignore these?

— Reply to this email directly, view it on GitHubhttps://github.com/ggreen86/XLSX-Workbook-Class/issues/83#issuecomment-1496229526, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AGWB33NPQPWOH4VLAIDL5CLW7RARDANCNFSM6AAAAAAWQRJJLY. You are receiving this because you modified the open/close state.Message ID: @.**@.>>

pivoten-psherwood commented 1 year ago

Commenting out the SET STEP ON fixed the issue.

Thanks!

Phil

On Tue, Apr 4, 2023 at 12:25 PM ggreen86 @.***> wrote:

The class is ignoring those extra files and not including them. You can comment out the SET STEP ON after the OTHERWISE statement if you want to just to be sure it does not stop there.

From: pivoten-psherwood @.> Sent: Tuesday, April 4, 2023 12:00 PM To: ggreen86/XLSX-Workbook-Class @.> Cc: ggreen86 @.>; State change @.> Subject: Re: [ggreen86/XLSX-Workbook-Class] RelType = "customXML" hits SET STEP ON (Issue #83)

I was able to do the same. This came from a client so I'm not sure of the workaround. Since I don't know what is adding these extra files I don't know how to tell them to correct it. Can the OpenXLSXWorkbook method just ignore these?

— Reply to this email directly, view it on GitHub< https://github.com/ggreen86/XLSX-Workbook-Class/issues/83#issuecomment-1496229526>, or unsubscribe< https://github.com/notifications/unsubscribe-auth/AGWB33NPQPWOH4VLAIDL5CLW7RARDANCNFSM6AAAAAAWQRJJLY>.

You are receiving this because you modified the open/close state.Message ID: @.**@.>>

— Reply to this email directly, view it on GitHub https://github.com/ggreen86/XLSX-Workbook-Class/issues/83#issuecomment-1496265636, or unsubscribe https://github.com/notifications/unsubscribe-auth/A33NFHO673TTMFMN2RNEGKTW7RDPDANCNFSM6AAAAAAWQRJJLY . You are receiving this because you authored the thread.Message ID: @.***>

pivoten-psherwood commented 1 year ago

I noticed that somewhere along the way SHEETCNT got dropped from xl_workbook. The diagrams still show it but it's not in the table. I was able to get around it but was curious when that dropped out?