search

ggriffiths / MyOrange

Software Implementation course project
1 stars 0 forks source link

ng-view #1

Open kdaziz opened 10 years ago

kdaziz commented 10 years ago

Is there a reason it looks like we are not actually using ng-view but hiding/displaying divs instead in the nav ctrl? I think I've got a fix for it but I wanted to check if it was actually broken first

ggriffiths commented 10 years ago

Yeah, it looks like we're not using it, but you'll notice that removing the ng-view div will cause everything to not work. Not really an expert on angular yet, but it seems to initialize the code in js/app.js that hides/shows each part.

If you have a fix go for it, but I think the issue has to do with us using normal Google APIs instead of an angular directive for each API. i.e. https://github.com/angular-ui/ui-map . I found out about this issue after we started, and I figured it was probably a little late to switch over.

kdaziz commented 10 years ago

My fix will make integration nothing more than adding the proper Githubissues.

  • Githubissues is a development platform for aggregating issues.