search

ggrossetie / asciidoctor-emoji

Asciidoctor.js extension to add emoji in your document!
MIT License
7 stars 5 forks source link

Offline Emoji #10

Closed clsource closed 3 years ago

clsource commented 4 years ago

Hello, thanks for this wonderful extension. It works superb!. One idea is having an offline option so emojis are downloaded, using the local image instead of the twemoji url. This would be specially useful when using pdf output.

Thanks again 👍

ggrossetie commented 4 years ago

Hello @clsource and thanks for your kind words :blush: Indeed that's a good idea, I will see what I can do.

ggrossetie commented 4 years ago

Not sure if I will find the time to do it but if someone wants to give it a try feel free to submit a pull request :+1:

ggrossetie commented 3 years ago

Fixed in 9b5865a thanks to @cbergmann 🥇

ghost commented 7 months ago

@ggrossetie I guess the README should be updated? The ref to a CDN is a no go for us, so this MR impacts this decision dramatically!

https://github.com/ggrossetie/asciidoctor-emoji?tab=readme-ov-file#how-

ggrossetie commented 7 months ago

@qa-alexander-eimer We were also using a CDN before. Are you saying that you don't have access to the CDN during build time?

ghost commented 7 months ago

@ggrossetie Okay I probably misunderstood the mechanisms of Ascidoctor and the extension. So please correct me in any false assumptions I have.

To me the README "How?" section gives the impression, that the HTML generated is dependant on a CDN. To me it looks like the svg is pulled from the CDN when the final result is viewed by the user. If that is true, it would be a major flaw as I would have hoped, that the svg is inlined into the HTML or the svg is stored in the images folder of the module.

How does this extension work?

I guess the README section "How?" should be written more clear, as it seem not precise enough for me.

ggrossetie commented 7 months ago

Before this pull request:

<img src="https://twemoji.maxcdn.com/2/svg/1f41e.svg" alt="beetle" width="24px" height="24px">

After this pull request:

<img class="emoji" draggable="false" height="24px" width="24px" src="data:image/svg+xml;base64,PHN2ZyB4bWxucz0iaHR0cDovL3d3dy53My5vcmcvMjAwMC9zdmciIHZpZXdCb3g9IjAgMCAzNiAzNiI+PGNpcmNsZSBmaWxsPSIjMzEzNzNEIiBjeD0iMTgiIGN5PSIxOCIgcj0iMTgiLz48L3N2Zz4=" />

The base64 is generated from the CDN but the client (HTML) is not dependent on the CDN.

ghost commented 7 months ago

@ggrossetie Ok, understood. Then I did understand the ticket correct.

My point is now, the README.md on the "repo startpage" has this section: image It appears to me, that the section need an adaption as it doesn't fit the current code, does it?