search

ggrossetie / asciidoctor-emoji

Asciidoctor.js extension to add emoji in your document!
MIT License
7 stars 5 forks source link

Asciidoctorjs 3 #90

Closed xavier-calland closed 11 months ago

xavier-calland commented 11 months ago

Issue #89

ggrossetie commented 11 months ago

Thanks! Could you please extract the CDN update (from https://twemoji.maxcdn.com to https://cdn.jsdelivr.net/npm/twemoji@latest) into a dedicated pull request?

Also, we need to say on "libnpmpublish": "~6.0". They frequently introduce breaking changes and as a result our publish task is probably not working with anything > 6.x.

Any reason to use ^ instead of ~ ? I would prefer to keep using ~x.y (unless you have a strong case for ^).

xavier-calland commented 11 months ago

If the lib uses and respects SemVer(it may be a too big assomption), we can use ^x.y without risk. It will only use version x.z (with z >= y), so no breaking changes will be introduced. This allows automatic updates with npm update.

If you prefer using ~, no problem :)

I prepare a PR for the CDN update.

ggrossetie commented 11 months ago

I've updated dependencies in https://github.com/ggrossetie/asciidoctor-emoji/commit/85959ac9081bc1bd150e17cc78bbf42a27213b48. I just released version 0.5.0. Could you please give it a try?

xavier-calland commented 11 months ago

Version 0.5.0 work fine for me. Thanks !