ggrossetie / asciidoctor-web-pdf

Convert AsciiDoc documents to PDF using web technologies
https://asciidoctor.org
MIT License
450 stars 92 forks source link

resolves #457 add a README.md for each example #458

Closed wh81752 closed 3 years ago

wh81752 commented 3 years ago

PR for issue #457 - simple README.md in each sample folder on how to reproduce.

ggrossetie commented 3 years ago

@wh81752 I cannot push on your branch, could you please enable "Allow edits from maintainers"? I want to do the following edits:

wh81752 commented 3 years ago

@Mogztter - hmm, Allow edits by maintainers is ticked.

wh81752 commented 3 years ago

Screenshot 2021-04-15 at 22 01 35

@Mogztter - see, it's enabled.

wh81752 commented 3 years ago

@Mogztter - invited you as contributor to my (forked) repo. Perhaps this may work. Otherwise, how about to create a new branch in your original repo, modify and finally push from there?

wh81752 commented 3 years ago

@Mogztter - updated this PR:

ggrossetie commented 3 years ago

MY bad I wasn't pushing to the right branch 😓

updated this PR

Thanks, I will rebase my changes 👍🏻

wh81752 commented 3 years ago

@Mogztter - would you mind to add me as contributor?

ggrossetie commented 3 years ago

You are a contributor since you've contributed changes but I think you need to link this email address (wh81752@bitio.org) to your GitHub profile.

wh81752 commented 3 years ago

Ah, I see. Thx.

On Sat, Apr 17, 2021 at 1:16 PM Guillaume Grossetie < @.***> wrote:

You are a contributor since you've contributed changes but I think you need to link this email address @.***) to your GitHub profile.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Mogztter/asciidoctor-web-pdf/pull/458#issuecomment-821807291, or unsubscribe https://github.com/notifications/unsubscribe-auth/AB42TPLVH76DHNTIST75KZDTJFUXXANCNFSM427BJM4Q .

-- Wolfgang Häfelinger häfelinger IT - Applied Software Architecture http://www.haefelinger.it +49 1520 32 52 981 (+31 648 27 61 59)