Closed wh81752 closed 3 years ago
@Mogztter - it basically works, still some fine tuning necessary => move cursor after download status-lines when finished OR -- perhaps better -- change PRE/POST condition in such a way, that cursor is at line after multi-line area. So that further logs to come will not overwrite status-line area. Nonetheless, it basically works.
Just a minor, while important, improvement:
Create directory structure
===========================
Downloading browser for mac 16%
Downloading browser for win 11%
Downloading browser for linux 7%
===========================
^
TTY cursor is now a position indicated by caret (^
) after each status line update. Whatever happens then, this modification ensures that follow-up log statements within the TTY are not overwriting the update-status block. One notable exception though would is of course kill -9
, i.e. process killing.
@Mogztter - this PR supersedes #488, however, there is no dependency on #488. So we can drop #488 in favor of this one.
Thanks, I will give it a try on my macOS laptop 🍎
It's working great but using a single line is probably less confusing (especially if you press
Downloading browser [mac: 1%]
Downloading browsers [linux: 1%, mac: 1%, win: 1%]
Please review: https://github.com/wh81752/asciidoctor-web-pdf/pull/1
@Mogztter - proper single-line download status now, I guess ready to be merged with master.
Btw, I wonder what the best GIT strategy now is. My approach would be:
Is that the right way to do?
@wh81752 Yes, you can use an interactive rebase: git rebase -i origin/master
(in this case, origin
is https://github.com/Mogztter/asciidoctor-web-pdf
) to squash all commits. You can also reword the first commit (while doing the rebase) to accurately describe what you did.
Then, force push on your branch. You need to force push because commits have changed.
If all goes well, you will have a pull request with a single commit.
@Mogztter - here we go, ready to merge.###
Thanks and merged!
A PR for getting a multi-line download status: Expect to see something like this on downloading Chromium for supported platforms: