search

ggrossetie / asciidoctor-web-pdf

Convert AsciiDoc documents to PDF using web technologies
https://asciidoctor.org
MIT License
450 stars 92 forks source link

In the examples, pagedjs inclusion is missed. #502

Open shahryareiv opened 3 years ago

shahryareiv commented 3 years ago

With a custom template pagedjs is not inserted automatically. It is possible to insert it manually, anyway, but the provided examples do not contain that, causing the user wonder why some features do not work. For me it was margin contents, which do not work without pagejs called/included.

shahryareiv commented 3 years ago

It seem actually below lines in the document-converter.js should be included in any other custom convertor.

<script>
${this.pagedContent}
${this.pagedRendering}
${this.repeatTableElementsContent}
</script>
ggrossetie commented 3 years ago

Hey @shahryareiv

I'm not sure about this one. Including Paged.js has a few drawbacks and we are not using it in all examples because not all examples need "advanced" paged media features.

Also, please note that examples are really "inspirational material", to demonstrate some capabilities. They are not general purpose converters.

Having said that, and since we now have a README.md for each example, we can probably improve the documentation to explicitly mention if Paged.js is included or not.