search

ggrossetie / asciidoctor-web-pdf

Convert AsciiDoc documents to PDF using web technologies
https://asciidoctor.org
MIT License
455 stars 92 forks source link

Add Docker Usage #666

Closed cinhtau closed 2 years ago

cinhtau commented 2 years ago

Based on issue #306

https://github.com/Mogztter/asciidoctor-web-pdf/issues/306

I have added in the README the docker usage and a straightforward Dockerfile.

Everything works out of the box. As enhancement I propose to push it into the public docker registry or use the public github docker registry.

ggrossetie commented 2 years ago

Hey! Thanks, it looks good 🤩

I will carefully review it in the next few days. Once thing I would like to do is run the tests suite against the Docker image. That would ensure that we are able to build an image from the Dockerfile and that everything is working as expected.

I would also like to support reading/writing from stdin/stdout to allow to convert an AsciiDoc document to PDF without mounting a volume:

cat doc.adoc | docker run -i asciidoctor-web-pdf asciidoctor-web-pdf - > doc.pdf
ggrossetie commented 2 years ago

I forgot I had already done some work: https://github.com/Mogztter/asciidoctor-web-pdf/pull/652 I will merge your changes with my branch.

cinhtau commented 2 years ago

I forgot I had already done some work: #652 I will merge your changes with my branch.

Maybe just close this PR and incorporate the changes you need.

After seeing your Dockerfile I understood that you build the application and copy it to the application folder.

ggrossetie commented 2 years ago

superseded by #652

Thanks again for your great work, I've merged your changes into #652 and made a few adjustments.