search

ggrossetie / asciidoctor-web-pdf

Convert AsciiDoc documents to PDF using web technologies
https://asciidoctor.org
MIT License
455 stars 92 forks source link

Update outline.js #677

Closed lucianciolacu closed 1 year ago

lucianciolacu commented 1 year ago

@ggrossetie I have noticed that even though my anchor destination was correct, I was getting the initial error. This is the effect of the fact that the generateWarningsAboutMissingDestinations function must to decode the target of the anchors that are now encoded. See the values below:

Item destination known-issues#253A#253A#253A                                                                                                             
Valid destination targets:  [ '/known-issues:::', '/legacy-devices:::' ]

If you can, please review my proposal. It fixed all these false positive errors in my case. Thanks!

lucianciolacu commented 1 year ago

The issue that is fixed here was introduced in https://github.com/ggrossetie/asciidoctor-web-pdf/issues/340

ggrossetie commented 1 year ago

It seems that https://bugs.chromium.org/p/chromium/issues/detail?id=985254 is now fixed

Could you please remove:

https://github.com/ggrossetie/asciidoctor-web-pdf/blob/c613be393cd667aa3ced70d02ec05e7b4cfdf4db/lib/outline.js#L23-L24

lucianciolacu commented 1 year ago

@ggrossetie reverted my initial fix for the warning function & removed the encoding of section id as you pointed out

ggrossetie commented 1 year ago

Thanks!