Upgrade paged.js to v0.4.3

ggrossetie / asciidoctor-web-pdf

Convert AsciiDoc documents to PDF using web technologies

https://asciidoctor.org

MIT License

455 stars 92 forks source link

Upgrade paged.js to v0.4.3 #692

Open markduan opened 1 year ago

markduan commented 1 year ago

This PR contains the following updates:

remove @ggrossetie/pagedjs and use the latest version Paged.js polyfill
handle page crash case caused by missing tbody in table element in the generated html

ggrossetie commented 1 year ago

@markduan could you please explain what's the goal? I don't mind using the latest version of Paged.js since my fork is outdated (even though it had a few important fixes but maybe they are now available upstream).

ggrossetie commented 1 year ago

As you can see a few tests are failing probably because Paged.js 0.4.3 does not include fixes I made on my fork.

markduan commented 1 year ago

As you can see a few tests are failing probably because Paged.js 0.4.3 does not include fixes I made on my fork.

I can't find the source code for @ggrossetie/pagedjs, please let me know and maybe I can try to merge both sides of the fix.