search

ggrossetie / unxhr

Synchronous and asynchronous XMLHttpRequest for Node
MIT License
0 stars 3 forks source link

Increase default value of maxBuffer (and make it configurable) #41

Closed ggrossetie closed 3 years ago

ggrossetie commented 3 years ago

resolves #39

mariotoffia commented 3 years ago

Hi and thanks @Mogztter for this bugfix. Will the UNXHR_MAX_BUFFER environment variable be configureable (as well) via a kroki-xyz setting in the asciidoc document or may be set in the asciidoc vs plugin?

... or is it this environment variable - period? :)

Cheers, Mario :)

ggrossetie commented 3 years ago

Hey @mariotoffia

Hi and thanks @Mogztter for this bugfix. Will the UNXHR_MAX_BUFFER environment variable be configureable (as well) via a kroki-xyz setting in the asciidoc document or may be set in the asciidoc vs plugin?

No, it will only be an environment variable but 100 MB should be more than enough. This hard limit is specific to Node.js (JavaScript runtime) and not tied to Kroki or Asciidoctor so it does not make sense to introduce a setting or an AsciiDoc attribute.

If you are working with diagrams that are larger than 100 MB then you probably need to fine tune your runtime environment (Node.js) hence the environment variable.