ggsava / block-this

Block This - FREE DNS based Ad Blocker for Android
https://block-this.com
GNU General Public License v3.0
374 stars 63 forks source link

Permissions #22

Open IzzySoft opened 7 years ago

IzzySoft commented 7 years ago

Just curious: for what does an AdBlocker need the READ_PHONE_STATE permission? This makes the app suspicious to especially privacy-aware people (I got that response when recommending your app).

If it's for the "usual purpose" (i.e. to "background" on incoming calls, which the "official developer documentation" mentions it for): I don't see how that should make sense. An AdBlocker should work in the background anyway, and configuration/settings pages make no sound and play no video. So there's nothing to interfere with phone calls. And even if there were, there are other solutions available.

TL;DR: Would you consider removing that permission requirement?

ggsava commented 7 years ago

Thanks @IzzySoft. I thought I already removed that, I will take a look at it again. I think it might be from something I tested in a previous version.. but I believe its not necessary anymore.

IzzySoft commented 7 years ago

Thanks for your fast reaction, @ggsava – I will report that back to the reporting user, uh... "on the double" :laughing: Looking forward then to the next version without that permission :+1:

IzzySoft commented 6 years ago

Almost a year later: Will there be a release anytime soon to remove that? Last release was quite a while ago, and according to the repo there has been some more development since (though the last change was 3 months back).