search

ggsbv / ItemisedBillKata

Itemised Bill Kata, codeX 2017
0 stars 0 forks source link

Please show me the better way, LOL. #1

Open ggsbv opened 7 years ago

ggsbv commented 7 years ago

@avermeulen Kyk net die nonsense wat ek hier aangejaag het.

Wel, te minste werk dit, maar goeie genade ons, het ek darem 'n langwindige manier gekies om die doel te bereik.

Nuuskierig oor wat jy dink, laat my weet!

avermeulen commented 7 years ago

@ggsbv - not looking too bad at first glance. You need to unit test edge cases. You in generally only have one unit test scenario per function. Like for example in the '00h00m00s' one you should test minute & second combinations & second only ones as well.