url_template updates - Githubissues

ggtracker / sc2reader

Extracts gameplay information from Starcraft II replay files

http://pypi.python.org/pypi/sc2reader

MIT License

145 stars 144 forks source link

url_template updates #151

Closed Andrene closed 3 years ago

Andrene commented 3 years ago

load_map=True should now work on CN and NA out of the box.

Updated the other url_templates to use the new blizzard CDN, although I neglected to include CN in them as adding it would be a bit more effort/it seems those were rarely used anyway since no one complained they were broken.

See issue #140

Feel free to tell me to change my solution if it is too janky (I know its janky, just not if it too janky)

Andrene commented 3 years ago

Well, I'm not sure exactly why the style check failed(or at least it doesn't tell me what to change, and why it doesn't like it.)... The only thing I changed in utils.py was the janky solution to the cn depot problem. Guess I'll figure out a non janky solution.

StoicLoofah commented 3 years ago

Let me know if you need a versioned release for this