ggtracker / sc2reader

Extracts gameplay information from Starcraft II replay files
http://pypi.python.org/pypi/sc2reader
MIT License
145 stars 144 forks source link

Dialog control event #201

Closed Andrene closed 4 months ago

Andrene commented 4 months ago

Adds the DialogControlEvent game event type.

This is for interactions with dialogs ingame and allows for some neat data collection as it looks to generate an event when a trigger modifys a dialog field aswell.

Control ID seems for the most part useless Event types seem to match with the ones listed here https://mapster.talv.space/galaxy/reference/preset-control-event-type Event data contains what a dialog text box was changedto, if a check box checked or unchecked, etc

Andrene commented 4 months ago

Style check is failing on a function since it thinks "assertIn" is a typo :) self.assertIn("PlayerLeaveEvent", capturedOutput.getvalue())

cclauss commented 4 months ago

Add assertin (all lowercase) to this line. https://github.com/ggtracker/sc2reader/blob/a7778d0436ba37540bfd11f1892a502f5b9c1456/.circleci/config.yml#L21

Andrene commented 4 months ago

Yep, it was a wee agressive in readers.py

StoicLoofah commented 4 months ago

Thanks!