search

ggtracker / sc2reader

Extracts gameplay information from Starcraft II replay files
http://pypi.python.org/pypi/sc2reader
MIT License
145 stars 144 forks source link

Early detection of events without a player #62

Closed cclauss closed 6 years ago

cclauss commented 6 years ago

There are a class of issues like #61 where event.player is None so this PR should print the event in the stacktrace.

StoicLoofah commented 6 years ago

Thanks for taking a shot at this! Seems like a reasonable check to have, but see #61 for the rougher underlying issue here. Have you seen this same problem in other cases that need to be addressed? My concern with merging this change in on its own will cover up issues (even if it is supposed to be included in the output)