Fix replay tests - Githubissues

ggtracker / sc2reader

Extracts gameplay information from Starcraft II replay files

http://pypi.python.org/pypi/sc2reader

MIT License

145 stars 144 forks source link

Fix replay tests #82

Closed dneise closed 5 years ago

dneise commented 5 years ago

should fix #78

For reviewers:

This PR contains some automatic style fixes, using black -l 127
Apart from that, the only interesting commits are:
- a403034cb30fd97b5e7b5b02a106adcf2b29e467
- 57c7064446c03a2c576bd3cfe73f0dd0595de2b4

dneise commented 5 years ago

Ah so it seems not only did test_replays/test_all.py fail. Also test_s2gs/test_all.py fails.

So I am also trying to fix that now...

dsjoerg commented 5 years ago

I think the s2gs functionality of this library may be safely removed. We added s2gs parsing back in 2012 because back then s2gs was a valuable source of information about matches for GGTracker. But the only way to get s2gs files en masse is to automate the SC2 client, and I'm not aware of anyone doing that kind of thing these days.

dneise commented 5 years ago

Thanks @dsjoerg for this comment. I propose to have a dedicated issue, in order to discuss the removal of an unused feature. Since the purpose of this PR was to make some existing tests run again.

dneise commented 5 years ago

Should we merge this?

cclauss commented 5 years ago

Are the format modification made by python/black?

dneise commented 5 years ago

yes. Sorry .. was maybe a bit forward of me. Should I remove that?

cclauss commented 5 years ago

I am a fan of python/black but others are free to disagree.

StoicLoofah commented 5 years ago

Looks good to me. Thanks for fixing this!

I am also okay using black. I'll make an issue for it