search

ggtracker / sc2reader

Extracts gameplay information from Starcraft II replay files
http://pypi.python.org/pypi/sc2reader
MIT License
145 stars 144 forks source link

reformat codebase using python/black #87

Closed dneise closed 5 years ago

dneise commented 5 years ago

I open this PR just to see if the test are still running after reformatting using python/black

dneise commented 5 years ago

Since black does not exist for Py2, I first decided to verify codestyle only on Py3 (after all the style check is Py version independent). But having conditional steps turned out to be rather hard.

In the end I thought:

Why not define one dedicated job for all style checks?

So now the Style checks are run using py3.7 and for all other Pythons we skip the style checks and only build and run the test suite.

dneise commented 5 years ago

@cclauss and @StoicLoofah could this be merged?

StoicLoofah commented 5 years ago

sorry for being delinquent on merging the other branches, but there are now conflicts to resolve here. @dneise can you take a look at those?

Regarding the discussion on documenting and enforcing black, this is exactly what i was hoping for. thanks for integrating those!

... now i need to get black setup myself =)

cclauss commented 5 years ago

The precommit hook is the way to go... It blackens the code in the commit process.

dneise commented 5 years ago

@StoicLoofah ok, I think this can be merged now

dneise commented 5 years ago

@StoicLoofah

I am sorry, this PR has a bit of an ugly commit history. Maybe you could to a squash + merge commit? in order to have a cleaner history?

After all, the only thing I did in this PR was black . and then figure out how to verify blackness on circleci.