search

ggunti / react-native-amazing-cropper

Image cropper for react native using Animated API
MIT License
145 stars 83 forks source link

Unmaintained Dependency - react-native-image-rotate #24

Open ahmed-ismail-nt opened 4 years ago

ahmed-ismail-nt commented 4 years ago

Thank you for this package. It's a good package, I like it more than the alternatives and it has a lot of promise.

Issue The react-native-image-rotate package is no longer being maintained.

At first glance, these are some issues already cropping up:

  1. iOS-specific: The package uses deprecated methods from RCTImageStoreManager.h in RNImageRotate/ImageRotateModule.m. The imports need to be updated as well.
  2. Android-specific: The android/build.gradle file needs to be updated.

How will you be handling this in future releases?

ggunti commented 4 years ago

Can you recommend a similar maintained library that we could use instead react-native-image-rotate? We could use ImageManipulator, but I think that it will enforce to use expo and I don't like the idea (in bare react native projects can be used only if we install also the react-native-unimodules package, which is +1 dependency, which is not desired). An another alternative could be to remove the rotation feature from this package.

NateC3 commented 4 years ago

Maybe you could remove the rotation feature for the time being until an alternative is found? That way we can continue using this.

sergiulucaci commented 4 years ago

I would suggest to remove the rotation feature too.

bitlab-code commented 4 years ago

currently expo ship with a bare workflow, alternatively app bootstrapped with react-native cli can easy install unimodules so (imho) use the expo ImageManipulator it's a good idea

or you can think to fork and edit ImageManipulator just like this test

kidculli commented 2 years ago

Can you recommend a similar maintained library that we could use instead react-native-image-rotate? We could use ImageManipulator, but I think that it will enforce to use expo and I don't like the idea (in bare react native projects can be used only if we install also the react-native-unimodules package, which is +1 dependency, which is not desired). An another alternative could be to remove the rotation feature from this package.

https://github.com/pontusab/react-native-image-manipulator

This package seems to be maintained and has a rotate method

ggunti commented 2 years ago

@kidculli Tried it and it does not seem to work properly.