ggventurini / python-deltasigma

A port of the MATLAB Delta Sigma Toolbox based on free software and very little sleep
python-deltasigma.io
Other
86 stars 54 forks source link

Support for different TF representations is inconsistent #16

Closed ggventurini closed 10 years ago

ggventurini commented 10 years ago

Sometimes a TF can be provided only with "simplified zpk form", ie (ndarray zeros, ndarray poles, scalar gain), sometimes an LTI object from scipy is accepted too, sometimes a tuple representation like (ndarray num, ndarray den) is also valid.

ggventurini commented 10 years ago

Support for different representations is provided through:

Notice we need the latter two because scipy provides similar functionality but has no support for the ABCD matrix representation, which python-deltasigma supports, coherently with the MATLAB toolbox.

Also, a method _is_ABCD(), which would theoretically complement the _is*() above, was not implemented since if no info is given about the TF, the best we can do is return is_instance(np.ndarray), which the user can do himself.

Converting between ABCD and A,B,C,D representations is done elsewhere, through _partitionABCD().

Finally, commit e31c1ac9ef01139e98942222ba47f3d8f3049860 should be the last change set required to close this issue, if I did not miss anything.