search

gh-cli-for-education / gh-edu

A pluggable extension of gh-cli to assist educators and students using GitHub Education
https://github.com/gh-cli-for-education/TFG-2122-Cristo-Garcia-Gonzalez
3 stars 0 forks source link

information leak #4

Open crguezl opened 2 years ago

crguezl commented 2 years ago

@GGCristo what do you think of this?

The file config.json contains data (students names, organizations, etc.) that must remain secret.

Since the repo we are using is public, the current info in the config file is exposed.

I am going to change the visibility of the repo to private until we found a satisfactory solution to this.

GGCristo commented 2 years ago

yes, this way I don't have to remember to clean it every time I do a push.

crguezl commented 2 years ago

@GGCristo ,

A proposal may be to have an empty config.json file that is the one under control version and to overwrite it with the local one.

May be we can automate push and pull task inside the package.json to make this less error-prone.

GGCristo commented 2 years ago

I will create a git pre-push hook for it, but is not the priority right now. For the time being, having the repository in private will do.

crguezl commented 2 years ago

¿Cómo vas con la actividad 7?

Casiano Rodríguez León

Departamento de Ingeniería Informática y de Sistemas Escuela Superior de Ingeniería y Tecnología Despacho P2037 Planta 2 Módulo A - AN.4A. ESIT Campus Universitario Anchieta C/ San Francisco de Paula s/n 38206 La Laguna. S/C de Tenerife

Email: c @.**@. @.***> Teléfono: +34 922 318187

El dom, 8 may 2022 a las 12:12, Cristo García @.***>) escribió:

I will create a git pre-push hook for it, but is not the priority right now. For the time being, having the repository in private will do.

— Reply to this email directly, view it on GitHub https://github.com/gh-cli-for-education/gh-edu/issues/4#issuecomment-1120398287, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAIW6GTE7GYGTPGQJHIE55LVI6OQ7ANCNFSM5VLYQJ6A . You are receiving this because you were assigned.Message ID: @.***>

GGCristo commented 2 years ago

@crguezl I added config.json to .gitignore and removed it from remote. Now the system detect if config.json is missing and create one if necessary. So we can make this repo public again. Maybe you get some errors because I did some push force, do a fresh install if there is any problem.