gh0stzk / dotfiles

BSPWM environment with 18 themes. With a theme selector to change on the fly.
GNU General Public License v3.0
2.86k stars 212 forks source link

Found some bugs #203

Closed 0xN1nja closed 6 months ago

0xN1nja commented 6 months ago

Hey @gh0stzk! Your new rices look fantastic. I've been using an old fork of your dotfiles and made some heavy modifications to them, so I've been manually installing them. However, I found some bugs:

  1. When pressing mod + h or mod + u twice in z0mbi3 & andrea rice (which have the eww bar), the new HideBar script glitches and fails to render it properly.

  2. The bar in z0mbi3 rice doesn't react to hover events

  3. In the set_eww_colors function (found in Theme.sh of brenda, daniela, marisol), there's a typo in the string; it says "Eww colors for Emilia rice"

  4. In the set_term_config function (found in Theme.sh of marisol), there's another typo; it says "(Kanagawa) color scheme for Marisol Rice" instead of "(Dracula) color scheme for Marisol Rice".

gh0stzk commented 6 months ago

Thank you, the first one, i will check in deep. The second point i cant reproduce it, are you running the last eww binary?? in my case it works fine in all hover events.

will fix the typos asap.

gh0stzk commented 6 months ago

I already push the fix for hidebar and that must fix your first point. Be sure you use latest eww, because the script now uses the flag "active-windows" in eww command. Typos corrected. Your second point i cant reproduce it. be sure you use eww 0.5.0 eww -V

0xN1nja commented 6 months ago

I'm currently using version 0.5.0 of Eww. The HideScript is still not functioning properly for Andrea Rice. Additionally, there seems to be an issue with font rendering in the Daniela rice:

image

I also have a question regarding the difference between the old and new configurations in my bspwmrc:

Old configuration:

workspaces() {
    name=1
    for monitor in $(bspc query -M); do
        bspc monitor "${monitor}" -n "$name" -d '1' '2' '3' '4' '5' '6'
        #bspc monitor ${monitor} -n "$name" -d '' '' '' '' '' ''
        ((name++))
    done
}

New configuration:

for monitor in $(xrandr -q | grep -w 'connected' | cut -d' ' -f1); do
    bspc monitor "$monitor" -d '1' '2' '3' '4' '5' '6'
    #bspc monitor "$monitor" -d '' '' '' '' '' ''
done

What is the difference between them?

gh0stzk commented 6 months ago

For the bar in Daniela, did you copy the new Bebasneue.ttf and drop in your fonts dir??

The difference in that code is, use the xrander to get monitors name and the monitor is not added automatically, https://github.com/gh0stzk/dotfiles/wiki/Two-or-more-monitors-setup . But perfectly you can leave as the old code and will work too. the change is to let people configure their monitors.

I tested the andrea bar, and apparently it is a problem with eww, which cannot close or start the daemon if you press the keys continuously and too fast.

0xN1nja commented 6 months ago

After I copied Bebasneue.ttf to ~/.local, the bar was fixed. Thanks!

Lastly, in Brenda rice, the weather component isn't properly padded (when mpd isn't playing anything): image

But it gets padded when you play something with mpd: image

gh0stzk commented 6 months ago

Ready, i push the fixes.

gh0stzk commented 6 months ago

Will close this issue now, if you found something else, create a new issue pls.

0xN1nja commented 6 months ago

The weather component now receives additional padding when a song is being played: image

0xN1nja commented 6 months ago

Another bug: System tray is not rendering properly in Melissa rice (maybe related to polybar) image

0xN1nja commented 6 months ago

@gh0stzk sorry for the ping

gh0stzk commented 6 months ago

No problem i already fix the weather module, the discord icon, in systray i dont know, it only happend with discord or what app it is??? In my case nothing wrong.

Shot-2024-03-19-115101

I just got new laptop and i fixing/editing/Optmizing the battery and brightness modules in all rices, i will push the weather fix when i finish updating all the other things.