gh0stzk / dotfiles

BSPWM environment with 18 themes. With a theme selector to change on the fly.
GNU General Public License v3.0
2.46k stars 187 forks source link

Profilecard and a new control center widget #255

Closed 0xN1nja closed 4 weeks ago

0xN1nja commented 1 month ago

Hey @gh0stzk! So, this isn't really an issue, it's more of a suggestion that I thought I should share with you. I'm a big fan of your designing and eww components; I really like them.

In the commit https://github.com/gh0stzk/dotfiles/commit/b555ca9550312a5796db7b535d0899b541a332b5, you updated the profile card, which seemed a bit odd to me (I don't know how others felt about it), but I liked the previous version better.

So, I was suggesting that you could remove the new control center you introduced in the new profile card and make it like the previous one:

image

And, create a new widget named "Control center" that contains this content from the profile card:

image

I don't know how others will feel about this. If you/others don't like it, it's okay, I'll implement it in my fork.

0xN1nja commented 1 month ago

What do you guys think @AzhamProdLive @CuB3y0nd (sorry for the ping)

AzhamProdLive commented 1 month ago

So, my honest opinion, I don't really like it that much, it (the control widget) looks out of place imo, I'd prefer we keep the current ProfileCard widget, and maybe make it bigger, as making 2 different widgets for this seems weird for me.

I would keep it, honestly

gh0stzk commented 1 month ago

I liked the simplicity of the old one, but I wanted to make it more functional, but changing it again would make people complain because I try to make it not only a nice UI but also have good functionality.

AzhamProdLive commented 1 month ago

I liked the simplicity of the old one, but I wanted to make it more functional, but changing it again would make people complain because I try to make it not only a nice UI but also have good functionality.

If I can suggest anything, maybe making the Current profilecard bigger would be a nice addition? I happen to find this one a tad bit small

CuB3y0nd commented 1 month ago

Same idea as @AzhamProdLive , I think it can make a little bit bigger. I not usually use weights tho, but split a control center is weird, there's only six things in, I think it will be very small and not pretty sight. In addition, add shortkeys for eww weights is a good idea, I don't like use mouse open weights.

gh0stzk commented 1 month ago

All widgets are sizeless, their size depends on the content inside.

In this case, what you could do is open ~/.config/bspwm/eww/profilecard.yuck

The line 76 is :hexpand true below that add a line with this content:

:width 320

Shot-2024-06-05-064239

the 320 value looks fine but change it to your like.

AzhamProdLive commented 1 month ago

Oh, that's interesting, thanks for the tip