search

ghDaYuYu / foo_discogger

Discogger
55 stars 0 forks source link

Please allow customizing font #116

Closed plastikat closed 2 days ago

plastikat commented 2 weeks ago

Hello, thank you for your hard work maintaining and supporting this plugin!

It would be nice to be able to customize the font used to display text in plugin windows (setting a larger font size is what I miss most), but I am not sure how much effort would be required. As of now, there is no way to alter the font used, nether of the available font "settings classes" have any effect on this plugin's windows (personally, I use Columns UI, but I tested with Default UI too).

It looks it is up to each plugin to manage the font of its windows. For instance, the standard (track) Properties dialog (despite not being a plugin) has a specific Font entry in the menu under its Tools button, and this is the only way to alter its font. A similar option on the "UI Options" tab would be just perfect. Thanks again!

ghuDaYuYu commented 1 week ago

Hello, you are welcome... thanks for the feedback! The feature might be implemented in future release if synced with fb2k 'Colors and Fonts' preference options. I am not sure if that is a viable option without resorting to hacks. I will have a look asap. Best regards!

ghuDaYuYu commented 1 week ago

Hi plasticat, Due to time constraints, I am afraid that I am adding another beta/experimental feature here : )

Here is a screenshot with larger font sizes.

cust_fnt

The UI option could be a toggle 'Use 'Tabs' and 'Lists' font sizes specified in fb2k preferences'. I will update this issue with the next beta release (v1.0.21 Beta 3) when available.

plastikat commented 1 week ago

I much appreciate your effort @ghuDaYuYu and would be really thrilled to see this implemented, thank you. However, I would encourage you not to hurry and take the time needed to think all details through and implement the feature properly.

My biggest concern at the moment is whether the Colors and Fonts options of the Default UI will still be in effect when Columns UI is the interface of choice (which has its own Colors and Fonts configuration, separate from that of the Default UI). In case Colors and Fonts of the Default UI will still be regarded under Columns UI, I'd be fine with the current implementation draft, but I am not sure if it will.

It could be that this dichotomy of Colors and Fonts is the very reason the standard track Properties dialog (I mentioned in the opening message) has its own font configuration (separate from any Colors and Fonts) and maybe a similar approach would work better with this plugin too. But I am shooting in the dark here and rely on you to make a better assessment, thanks in advance.

ghuDaYuYu commented 1 week ago

Thanks for you feedback.

As far as I know, non-ui elements as foo_discogger do not need to consider the UI of choice, therefore font size should stay unaffected. Related to this, Foobar 2000 v2 introduced DUI/CUI compatibility improvements, so it may become a minimum requirement for the feature.

Properties dialog (I mentioned in the opening message) has its own font configuration (separate from any Colors and Fonts) and maybe a similar approach would work better with this plugin too.

I decided to turn down color customization, not viable at the moment. ... the initial requirement in the OP is still scheduled to be included in the next beta release, though.

ghuDaYuYu commented 1 week ago

Here is the latest beta release, it includes a new "UI Option" to increase the list font size. Please backup your foo_discogger.cfg file and tag mappings before installing. foo_discogger 1.0.21 Beta 3

Change log:

plastikat commented 1 week ago

Here is the latest beta release, it includes a new "UI Option" to increase the list font size...

Thanks a lot, @ghuDaYuYu, the new foobar2000 list font option works like a charm for me: with the option selected, the font of foo_discogger lists becomes identical to that of my playlists and this is just perfect!

plastikat commented 1 week ago

A small note on the upgrade (or rather downgrade) process: in case the user tries to roll back to a previous version of foo_discogger after trying the new beta, they will face a "Configuration incompatibility" warning immediately after Foobar2000 starts and the full plugin's configuration will be reset to its default state. In case the user does not have a backup of the configuration, they might very well lose it.

There likely isn't much room for improvement here (given the new configuration is not backward-compatible indeed), but an explicit caveat added to release notes (when the change makes its way into a release version) would let users be better prepared.

ghuDaYuYu commented 1 week ago

Nicely noted... warning was added above. As a DUI user, I was unaware of lists becoming identical to playlists in CUI. DUI has separate settings for lists and playlists, and personally, I would have liked it in CUI too. Hopefully, the component will provide further CUI specific customization in the future. Before I need to become used to CUI and the CUI SDK. All in all, I often missed bigger font sizes too and l am very glad you raised the issue.

I believe the current issue should be automatically closed on the next release... or maybe moved to the discussion area as reminder to continue working on CUI integration. Either way, thanks again for taking the time to explain the issue and improving the component 👍

plastikat commented 1 week ago

lists becom[e] identical to playlists in CUI DUI has separate settings for lists and playlists

Well, CUI has individually customizable font "categories" too (including those for lists and playlists). Things worked seamlessly for me because the Colors and Fonts settings are hierarchical in CUI and I have not modified the default model, where most "categories" inherit from the two topmost ones:

BTW, while implemented differently (in terms of GUI representation), Colors and Fonts are hierarchical in DUI as well: you can, for one example, check (and change) only the (topmost) Default "category" (leaving all others unchecked) and this change will affect all other "categories" (because, being unchecked, they inherit from Default).

Either way, thanks again for taking the time to explain the issue and improving the component 👍

Most credits are all yours =) Thanks again for finding time to work on this issue.

ghuDaYuYu commented 2 days ago

Closing the issue as the initial issue 'customizing font' is now included in v1.0.21.x Further customization are not excluded indeed! Feel free to open a new issue or discussion related to this topic. Thanks for you collaboration!