ghDaYuYu / foo_discogger

Discogger
57 stars 0 forks source link

Unable to disable writing DISCOGS_RELEASE_ID #120

Closed armak closed 1 month ago

armak commented 1 month ago

The option to disable writing DISCOGS_RELEASE_ID is either disabled, or does not work. Normally for some reason clicking on the right where the action column is, these options are disabled for a few of the ID tags. However, they can still be disabled for most of them by clicking on the left side. Even then however, the state doesn't properly disable for DISCOGS_RELEASE_ID. I do not want to write any of these ID tags into my files.

image

Note how the "write" action still remains enabled for the release ID.

armak commented 1 month ago

I was able work around this by manually this by exporting my config, editing the "write" field to "0", and reimporting, but doing so disabled the button to write the tags in the Preview window for some reason?

image

The button in the main Track Matching dialog still works though, so I'm ok with it for now, but probably still worth fixing the ability to disable writing these IDs so that the user interface is consistent and there are no quirks when the user chooses not to have them written.

ghuDaYuYu commented 1 month ago

The user interface is quite consistent... alright not 100% consistent. Grayed-out items usually mean 'disabled' not 'quirky item'.

The disabled 'Write tags' in the Preview means 'nothing to do'. That state is usually unknown in the previous dialog, so probably not related to your hack. I see... unless coming back from the preview panel.

About the DISCOGS_RELEASE_ID... The 'I do not want to write any of these ID tags into my files' is a fair argument, and will be taken into consideration. This issue will be closed soon. Might move it to the discussion area, as a feature request, idk yet. Thanks for your feedback.

frogworth commented 1 month ago

@armak I think @ghuDaYuYu is working on a different workflow for this, but tags like that which are greyed out can still be changed by holding down shift when you click.

ghuDaYuYu commented 1 month ago

Hi frogworth, You are right again! Let´s move the issue to the discussion...