search

ghDaYuYu / foo_discogger

Discogger
61 stars 0 forks source link

SUGGESTION - Selection of items in the right match tracks window minics on the left #22

Closed stephen147 closed 1 year ago

stephen147 commented 3 years ago

See attached.

image

ghuDaYuYu commented 3 years ago

Not sure to follow you in this one, sorry... as you mention the up & down buttons, being then able to move both selections simultaneously pressing those buttons?

stephen147 commented 3 years ago

Just when the right item is selected the left corresponding row is also highlighted. Basically that it follows what's selected on the right.

Obviously, this wouldn't happen when clicking on an item in the left pane as it will be required. But maybe this would be good so that you know when the two same items line up.

Hopefully, you can understand my gibberish. 😎

ghuDaYuYu commented 3 years ago

That´s what I though at first, as a visual reference 👍 Not a very nice solution but could be simple to line up single selections by double clicking items on the left or right 😎 Or maybe you already have some other method in mind

stephen147 commented 3 years ago

I'm thinking of another program that does this. https://www.filebot.net/ it works quite well.

ghuDaYuYu commented 3 years ago

... hopefully the new panel with alternate background color will make it easier to match tracks and files. List row with greater heights would be nice also.

ghuDaYuYu commented 2 years ago

Added to the To Do, maybe as an additional column rather than two list side by side... Maybe one day, not soon though, noted!

stephen147 commented 1 year ago

Hiya, :)

Would it be possible to open this again?

Here's what I was talking about in mp3tag. Clicking a row in the right columns matches the left but clicking a row in the left doesn't.

2023 02 03 (22-06-24)

ghuDaYuYu commented 1 year ago

Hi there! Sure!

ghuDaYuYu commented 1 year ago

Bear with me while I try to fix the coffee machine, I am experiencing some brain fog at the moment...

Just as introduction, the Discogs list and the local file list controls are derived from fb2k SDK libPPUI control classes. libPPUI will not happily accept modifications leading to rare, non-standard list behaviors. One can expect to be hacking the way through the standard list control event flow while implementing this sort of features.

Also, I wonder whether this feature would introduce uncertainty to the UI (context menu actions, drag and drop, key presses,... action will be (intuitively) affected?).

I just need to justify myself that the mod is worth the effort (IMHO only in one, rare case that you did not mention, will come back to his later).

ghuDaYuYu commented 1 year ago

My understanding so far is a requirement to change the right list behavior so that when one item is selected, the item occupying the same position on the left pane is also selected (to make sure when the two same items line up)? Although only in the right pane, why not also when left items are selected?

ghuDaYuYu commented 1 year ago

In my experience, I just missed this sort of assistance in the 'manage artwork' panel, with releases containing large amount of items, when resizing the dialog to its max size will still leave items above and below the panel boundaries. At the time, a new 'row number' column was added to solve this problem.

I wonder if that's the sort of scenario that we are trying to solve here. Otherwise, in my opinion, the alternating row background colors should suffice to line up items.

stephen147 commented 1 year ago

Yes clicking a row on the right pane will highlight the same row on the left pane.

But, I was maybe thinking of a comparison column showing the match percentage of the opposing row instead. It would be a handy visual to see how close each track is.

ghuDaYuYu commented 1 year ago

Alternating row background colors is not enough? I can understand it better in your latest GIF, where some columns are quite far apart.

stephen147 commented 1 year ago

The way mp3tag does it is the ideal solution. Row colours would be fine but not as good.

ghuDaYuYu commented 1 year ago

I disagree, in fact, I do not like it at all, I find it quite inconsistent. Of course, it's possible I could change my mind, but this component will most probably never mimic that functionality. There are too many uncertainties (you did not answer some questions in my late posts), and I can sense lots of additional patches required to integrate the change and maintain the UI cohesive. Though there could be coming soon a new context menu option of the sort of 'Find matching row' to show and select each other corresponding row as a way to assist matching in those cases when a large number of tracks are involved or/and a column to uniquely identify each row.

ghuDaYuYu commented 1 year ago

My bad English might have made them look as rhetoric questions, they weren't... I might be missing the point here. Time will tell... Anyway, thanks you for the improvement suggestion!

stephen147 commented 1 year ago

If you can implement different row colours it would be an improvement. Sorry I missed the questions.

ghuDaYuYu commented 1 year ago

Never mind, my fault not expressing them properly... 👍 The Different row colours AKA as 'Playlist' style option can already be found in the preferences window (UI tab).

I've made a note of the match percentage column idea. Thanks.

As side note, next updates may focus on writing individual values. Also related to that, the preview panel UI needs to be revised/reworked. ... and then also the to-do list (including this issue if necessary).

ghuDaYuYu commented 1 year ago

I am closing this suggestion as not feasible, too much technical involvement for little gain, or at least I am finding it hard to justify the effort. The other idea about a percentage or ratio of correctness for each match seams interesting... I'll have a look, problem is that the quality of the value will be relative to the quality of the algorithms currently in use, so I am in doubt about what precision will be achieved.