Separator in modified multi-value tags

[username116]

Hello,

I have a problem with Style tag (maybe Genre too) that have multiple values. If I manually change a value before saving, I think the separator ";" is not interpreted as a separator. For example here in the Style tag, I replaced a value "Classical" by "Modern Classical". I then show the result in Mp3Tag, and finally how I think it should be. Tested with foo_discogger 1.0.14 and foobar 2.0 beta 10 x86

I think I saw a spelling mistake here. Shouldn't it be "Apply" instead of "Appy"?

[ghuDaYuYu]

Hello, thanks for your feedback.

Yes, that 'Appy' should be 'Apply', also edited multi-values need to be trimmed,

Those two fixes will be included in 1.0.14.1.

About the current issue, unfortunately I can´t reproduce it here, just getting the results as you mentioned they should be (STYLE, DISCOGS_STYLE and GENRE).

Have you tried to edit DISCOGS_STYLE from the fb2k properties panel instead, does it make any difference?

[ghuDaYuYu]

Oh, I see... the bug might be in the Edit (in-place) in the preview panel, not the detailed preview. That Appy🍎 misled my tests... I´ll try to fix it as soon as possible, thanks!

[username116]

Yes, I used the properties panel of foobar2000, in fact it's by making a modification with it in DISCOGS_STYLE that I got the "correct result" (fourth screenshot), the semicolons interpreted as separators. I guess I would have the same result with the separator \\ in Mp3Tag. I show the results in Mp3Tag because I think the difference is not well visible in foobar2000, if I remember correctly in both cases foobar shows the values on one line with semicolons.

The tags DISCOGS_ARTIST_ID;DISCOGS_GENRE;DISCOGS_STYLE; are added in my foobar2000 settings : Preferences > Advanced > ... > Multivalue fields.

Sorry if I'm not very clear. I also use a translator. "Appy" is not the same issue, sorry. I hesitated to make two separate issues, now I know I should have.
If you have seen... then it's ok. Thanks a lot.

[username116]

Yes it happens when I make an edit with a click on the line (with the "Results" view), like this:

So yes, that's the Edit (in-place) in the preview panel. I could have been clearer.

[ghuDaYuYu]

It´s a great bug report! I should apologize I dont use the translator and grammar checker as often as I should! ... and of course the bug being reported is quite embarrasing indeed!

Below you can find 1.0.14.1 prelease, in case you´d like to give it a try and confirm it's working, maybe new bugs have been introduced...

Both preview and detailed preview were buggy, so there is an attempt to fix that, trimming values and the spelling.

For this pre-release, I had to define a reduced set of multivalue fields, though:

"ARTIST", "ALBUM ARTIST", "PRODUCER", "COMPOSER", "PERFORMER", "GENRE", "STYLE", "DISCOGS_GENRE", "DISCOGS_STYLE"

It will be great if you'd like to test this fix, but no obligation ☺️

Thanks again for your feedback, I am glad having a multivalue related topic being reported.

zipped 1.0.14.1 preview.zip

[username116]

I tried the 1.0.14.1 preview version. When I edit the tags of one file, it seems to be fine. I looked in Mp3Tag.

With several files (two or ten), "Write tags" does not work.

• when I don't edit the tags, I get this message :

• when I edit the tags, it crashes. Crash report: failure_00000006.zip (this report is for two files, contrary to the screenshot) I tried to manually add "Test" tags in Genre and Style like this:

DISCOGS_GENRE and DISCOGS_STYLE, these are my personal settings. The default tags used by Discogger are GENRE and STYLE. I have remapped them to DISCOGS_GENRE and DISCOGS_STYLE. I separate Discogs genres from my own tags. I also tried the default tags GENRE and STYLE, and it crashes too.

The picture of your profile is an album of Rita Mitsouko I think. Do you speak French? I do. L'image de votre profil est un album des Rita Mitsouko il me semble. Vous parlez français ? Moi oui.

[ghuDaYuYu]

Je comprends et parle un peu, mais je ne l'écris pas, en fait, je ne sais pas comment écrire dans une langue, je pense. J'ai adoré l'attitude de Rita quand nous étions plus jeunes, et je suis toujours un fan. Ma langue maternelle est l'espagnol... il peut être plus approprié comme documentation continuer avec l'anglais mais vous pouvez écrire dans la langue que vous souhaitez, bien sûr. Il n'y a pas beaucoup de gens ici et je ne pense pas que ce soit une poblema.

Creo que he resuelto algunos fallos...

I can not replicate those last two errors, fatal error and crash on this new 14.2

Fixing last preview:

• Edits only applied to the first track.
• Crash increasing multivalue set size.

Give it a try, if you like... no hurry, I might post a few more pre-releases here as I find time to continue testing.

Je vous remercie beaucoup pour votre aide!

Edit:

• 1.0.14.2 configuration files NOT backward compatible (to be run on new portable installations)

Edit2: fixed version id, added multivalue configuration preference

zipp 1.0.14.2 preview.zip

[username116]

I understand for Rita Mitsuko. They made some hits that are quite famous. I think technology is great for that. You can talk to people who have a different language and who are on the other side of the world.

Long story short: it works, except if I remap the tags. I tried version 1.0.14.2 preview with a new portable installation of foobar2000 2.0 beta 10 x86. I didn't have any crash.

When I don't edit the values, it works, the values are well separated, like before. When I edit the values:

• If I don't remap the tags: it works.
• If I remap the tags: it didn't work, the values are not separated (I put these new tags in the new multi-value configuration of Discogger and in the advanced preferences of foobar2000).

I hope I didn't make mistakes in my tests.

If it's useful for you, and you use Mp3tag : you can easily see the difference in the Genre and Style columns, or create a column for custom tags with this formula $meta_sep(discogs_genre,\\). I think the same kind of thing can be done in foobar.

DISCOGS_ARTIST_ID is regularly multi-value I think, when there are two artists on the song for example.

I saw another error. I try to export the Tag mapping configuration, it doesn't work. The console doesn't say anything. Maybe it needs to open another issue, but I only tried with the last preview.

Thanks for your work.

[username116]

I made an edit on my previous post:

• I did another try, I said something wrong: When I edit the values, If I don't remap the tags: it works. (even when I went back to the default tags after remapping)
• confusion between the words tag / value.

[ghuDaYuYu]

Thanks for the update 👍

Yes, the multi-value fields value was applying its default value instead of the user defined, etc

This new release, should fix the custom multi-value field, the tag mapping import/export dialog has also been patched, thanks for noticing.

The component now logs tag write operations to the console:

Just bare bone, but should provide some clues.

Also, to help troubleshooting, the preview panel stays open after clicking Write tags

... and a new option to copy values to the lead-in tab in the detailed preview.

That´s it for now... I am also using Mp3Tag as in your recommendation, thanks!

zipped 1.0.14.2 preview.zip

[ghuDaYuYu]

Hi, been reading, with a bit more time, from the beginning, checking how this issue is getting resolved.

• When I edit the tags of one file, it seems to be fine

This bug was found and fixed, it did affect the first item in a selection

• When I edit the tags, it crashes

It can be seen in your screen capture that pressing enter in DISCOGS_STYLE triggers an edit of the field below, DISCOGS_RELEASE_ID. That crashed as that field is protected. Bug was introduced while updating UI to dark mode. Should be fixed now.

• If I remap the tags, the values are not separated
• Going back to the default tags after remaping
• Confusion between the words tag/value

That is still unresolved, it might be worth to comment that currently, when the Tag mapping is committed (by applying changes in the tag mapping panel) all manual edits are invalidated and replaced by the generated values. That is the reason for the foot note in the detailed preview panel 'Values subjected to tag remapping'. Not sure if that will change soon. I would like to implement a right-click option to write individual tags in the normal preview panel first.

I wouldn´t bother much about confusion with the words just now, sometimes a bit of confusion or misunderstanding can´t be that bad.

• DISCOGS_ARTIST_ID is regularly multi-value

That would depend, in my opinion, if that´s helpful somehow (needed by an app, script, layout...). Related to this, there might be a bug showing in my last screenshot log, as it seams it shows a non-multivalue tag being saved as being one.

[username116]

I tried the latest version. Editing values with remapped tags works. The export / import of the tag mapping works.

• When I edit the tags, it crashes Fixed the previous time. Sorry, my mistake (confusion). It was: When I click on "Write tags" after editing the values.

• If I remap the tags, the values are not separated Fixed. Maybe the right word was "trimmed"(?).

• Going back to the default tags after remaping. I tried again. It works. I must have made a mistake in my first test.

• Confusion between the words tag/value This is not an issue. It's me when I write, I edited my comment. It is not important. I have trouble with the vocabulary.

• DISCOGS_ARTIST_ID is regularly multi-value I tried, if there are several artists the values are well (... trimmed?). The Discogger command to open "Web Artist Page" works. So that's ok for me.

There is a detail that surprised me the first time, because the window stays open now. When I edit the values, I set the radio button to "Results". After clicking on "Write tags", my edits are no longer displayed, the values revert to the Discogs values. However, my edits are saved, I can see them when I put the radio button on "Original". I don't know, maybe it's good like that. It's a detail.

For me it works fine now. The issue can be closed if you want. Thank you very much.

[ghuDaYuYu]

Trim as remove any leading or trailing spaces, haha

Yes, you are right. Once you save your edits, they become the original. Sadly, the Write tags button will close the dialog as before in the next release.

Maybe the issue can remain open until v1.0.15 release date...

... et merci beaucoup pour votre aide, nous avons trouvé de nombreux bugs qui sont passés inaperçus, jusqu'à la prochaine fois!

[ghuDaYuYu]

Changes:

• Option to auto-update config fields on Discogs multivalue tag detection.

Fixes:

• Crash saving Multi-value fields (preference panel)
• Edited multi-value saved as single value (Discogs multi-value fields holding just one value treated as single value fields).

Todo:

• Split value context menu option

zipped 1.0.14.3

[username116]

I have again crashes and error messages with your latest version. Tested with a new foobar2000 portable v2.0 beta 10 x86 + Discogger 1.0.14.3pr Without remapping to custom tags, without modification of the values, when I click on "Write tags" in the preview panel. It seems to be different if there are one or more files selected. Sometimes a crash, sometimes an error message, I don't know where the difference between the two comes from.

failure_00000001.zip

[ghuDaYuYu]

geesh! my bad... I had to undo a very (VERY) old fix to continue with these multi-value fix series, Unfortunately we are downgrading next release to alpha now, total uncertainty!

I fixed the crash affecting the Origamibiro release, thanks for the crash report.

... and here is 1.014.4 alpha, quite miraculous if it´s not crashing now and them, sorry.

zipp 1.0.14.4 alpha

I will refrain from posting 14.5 until I find time for a complete testing. but feel free (if not exhausted yet) to run if you are curious about were it crashes next! 💯

[ghuDaYuYu]

Fixes:

• Regressions caused by 1.0.14.3 update.
• Auto-append duplicated fields
• Detailed preview multi-values
• Crash overwriting .tm files
• Crash loading album artwork preview

Other fixes/revisions:

• Discard numeric suffixes

zipped 1.0.14.5 prerelease

[username116]

I'm trying it with remapped tags and modified values. It only works if the new box "Auto-update fields while saving Discogs tags" is checked. I don't know if this is normal. I try to do this:

With these settings:

After clicking on "write tags", the tags DISCOGS_GENRE and DISCOGS_STYLE are empty. The console says that. If I check the box "Auto-update fields..." and try again, it works.

[ghuDaYuYu]

Thanks for the test case, brief and to the point...

These are my results after 14.6 fixes, with auto-update fields turned off:

log saving unaltered results: log_write_res.txt log updating: log_update.txt log writing & updating in one go (user case in your post) log_write_res_and_edited.txt

Still need to test if editing from the detailed preview is bug free.

I'm trying it with remapped tags and modified values. It only works if the new box "Auto-update fields while saving Discogs tags" is checked. I don't know if this is normal.

No, there was a bug, forgot to disable it while testing... should be fixed now. Looking now at the config panel, it might be also helpful to add an option to disable all multi-value fields.

It seams that v1.0.14.3 was not as broken as I initially though, maybe problems will arise tagging specific releases.

Here is a brief 14.6 change log:

Fixes:

• multi-value field preference algo bug

Other fixes:

• import/export filename codepage
• text copied to clipboard not pasting to notepad 11

zip 1.0.14.6 prerelease

[username116]

I tried the 1.0.14.6 prerelease with the same albums, with edited values, with and without the checkbox. I also tagged some other albums. It worked, no bugs to report. The Auto-update function which adds itself a multi-value tag in the setting worked too.

Thanks for all the improvements.

[ghuDaYuYu]

You are welcome! Closing with v1.0.14.7