ghaerr / elks

Embeddable Linux Kernel Subset - Linux for 8086
Other
1.03k stars 108 forks source link

New names for Ethernet interfaces #1445

Closed Mellvik closed 2 years ago

Mellvik commented 2 years ago

Status:

Problem:

Solution (suggested):

Being in the middle of this, I can include these changes to the 'project'.

--M

ghaerr commented 2 years ago

Hello @Mellvik,

All sounds good, and probably good to go with the appended '0' as well, if you like. What new name are you thinking for the 3c509 family, /dev/3c0?

Please check the /etc scripts and other locations (e.g. MSDOS FAT fake dev table etc) to ensure they're updated with the new names (if any are used) as well.

Thank you!

Mellvik commented 2 years ago

Thank you @ghaerr-

I actually intended to leave the 3c509 alone for now. I don't see ELKS supporting any of the other EtherLink III interfaces (Microchannel, PCMCIA), so it remains a driver for a single interface type. That's admittedly inconsistent, so let's come up with something that can work. '3c' looks kinda weird to me and may create confusion if someone creates a driver for some other 3com interface (503, 505, ). 'ep' doesn't say much but that's what freebsd has been using forever. They use 'ed' for the 3c503 btw.

What do you think?

—M

  1. nov. 2022 kl. 16:56 skrev Gregory Haerr @.***>:

Hello @Mellvik https://github.com/Mellvik,

All sounds good, and probably good to with the appended '0' as well, if you like. What new name are you thinking for the 3c509 family, /dev/3c0?

Please check the /etc scripts and other locations (e.g. MSDOS FAT fake dev table etc) to ensure they're updated with the new names (if any are used) as well.

Thank you!

— Reply to this email directly, view it on GitHub https://github.com/jbruchon/elks/issues/1445#issuecomment-1302323553, or unsubscribe https://github.com/notifications/unsubscribe-auth/AA3WGOAB7EJWYAVSWLKIQHDWGPOD3ANCNFSM6AAAAAARV3HCOM. You are receiving this because you were mentioned.

ghaerr commented 2 years ago

Given your suggestion(s) to shorten the names of the devices, since they support more NICs with numbers that make sense when appended to the two-digit proposed name, AND given your suggestion that we append a '0' for the future case that we might support multiple NICs (or at least being able to select one of several installed), I suggest the following:

/dev/wd0
/dev/ne0
/dev/3c0

Additional reasons include having some sort of continuity for for our users, who may not be privy to this discussion and wonder what the device names mean when executing ls /dev. Keeping the first two letters of the old name, and adding a "NIC card number" seems to make the most sense to me, while providing consistency as well as a path forward for your NIC development.

Mellvik commented 2 years ago

Good, we'll go for that.Thank you @ghaerr.-M3. nov. 2022 kl. 19:16 skrev Gregory Haerr @.***>: Given your suggestion(s) to shorten the names of the devices, since they support more NICs with numbers that make sense when appended to the two-digit proposed name, AND given your suggestion that we append a '0' for the future case that we might support multiple NICs (or at least being able to select one of several installed), I suggest the following: /dev/wd0 /dev/ne0 /dev/3c0

Additional reasons include having some sort of continuity for for our users, who may not be privy to this discussion and wonder what the device names mean when executing ls /dev. Keeping the first two letters of the old name, and adding a "NIC card number" seems to make the most sense to me, while providing consistency as well as a path forward for your NIC development.

—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you were mentioned.Message ID: @.***>