ghahramani / viewpager

Google Play Music Tabs and View Pager
Apache License 2.0
47 stars 41 forks source link

Compiled version? #2

Open sschueller opened 10 years ago

sschueller commented 10 years ago

Is there a compiled version of the module available?

Thanks

ghahramani commented 10 years ago

Yes I will upload it tonight. I can't do it now. I'm not home now.

sschueller commented 10 years ago

Thanks, no rush, I was able to compile it now. However, having some issues with the eventhandlers crashing the app.

ricardoalcocer commented 10 years ago

@sschueller, it seems like you and I always end up in the same repos :) @dreamlearn, could you provide the compiled version?

ricardoalcocer commented 10 years ago

BTW, I was able to compile it without problems. I had to modify timodule.xml to remove the Android Theme section. It runs fine for 5 seconds until I get a "License Violation Detected" error:

[ERROR] TiVerify: (Timer-2) [1145,6126] License violation detected. Unlicensed module(s) detected. You must be a subscriber to use one or more of the modules included with this project.. Please contact Appcelerator Support.

UPDATE: Fixed it by changing the GUID in the manifest file and recompiling. It appears to be working properly now. :)

sschueller commented 10 years ago

@ricardoalcocer : We have to stop meeting this way :) Did you get the event listeners to work? There is a resource missing "com.astuetz.viewpager.extensions.PagerSlidingTabStrip". Wenn I added it I could not longer compile. I also tried it in InteliJ but couldn't get it compile.

More info here: https://developer.appcelerator.com/question/156109/google-play-viewpager-and-tabs-module . Click "Show 5 more comments" for a lot more info.

ricardoalcocer commented 10 years ago

@sschueller , the problem with the event listeners is that they are on a non-existent object, proxy. I changed it to tabs and it worked (tabs.addEventListener instead of proxy.addEventListener).

The only thinks I needed to to in order to properly compile were:

Then on the app, I added the listener like this:

 tabs.addEventListener(tabs.PAGE_SELECTED_EVENT_NAME, function () {
Ti.API.info("TAG: ", arguments.length, JSON.stringify(arguments));

});

All the rest works just great!

I forked the project. Go to https://github.com/ricardoalcocer/viewpager and you can either get the compiled project from the /dist folder, or grab the test app from /testapp. Eitherway, they already have the changes mentioned above, so it's ready for use.

ardiwine commented 9 years ago

@ricardoalcocer i tried to compile your testapp using 3.3.GA and 3.4.GA it wouldn't build. It was working fine on 3.2.3.GA

This is the error i got:

[ERROR] Application Installer abnormal process termination. Process exit value was 1
[ERROR] :  Failed to package application:
[ERROR] :  
[ERROR] :  /Users/ardiwine/Downloads/viewpager-master/testapp/build/android/res/values/attrs.xml:9: error: Attribute "dividerPadding" has already been defined
[ERROR] :  /Users/ardiwine/Downloads/viewpager-master/testapp/build/android/res/values/attrs.xml:14: error: Attribute "textAllCaps" has already been defined
ricardoalcocer commented 9 years ago

Hi,

That's a known issue but easy to solve. You'll have to remove those entries from the module's attr.xml because they're already set by Titanium. Here's a description:

https://github.com/dreamlearn/viewpager/issues/5

R

On Thu, Oct 2, 2014 at 7:17 PM, Edwin Ardiwinata notifications@github.com wrote:

@ricardoalcocer https://github.com/ricardoalcocer i tried to compile your testapp using 3.3.GA and 3.4.GA it wouldn't build. It was working fine on 3.2.3.GA

This is the error i got:

[ERROR] Application Installer abnormal process termination. Process exit value was 1 [ERROR] : Failed to package application: [ERROR] : [ERROR] : /Users/ardiwine/Downloads/viewpager-master/testapp/build/android/res/values/attrs.xml:9: error: Attribute "dividerPadding" has already been defined [ERROR] : /Users/ardiwine/Downloads/viewpager-master/testapp/build/android/res/values/attrs.xml:14: error: Attribute "textAllCaps" has already been defined

— Reply to this email directly or view it on GitHub https://github.com/dreamlearn/viewpager/issues/2#issuecomment-57740758.