Closed obaranov closed 5 years ago
Hi Oleksii,
Thanks a lot for contribution!!!
Would be perfect if you could bump project's version, then i can release it, otherwise i'll do this by myself tomorrow or on Wednesday.
Best regards, Vladimir
Am Fr., 8. Feb. 2019, 16:01 hat Oleksii Baranov notifications@github.com geschrieben:
Bump version of the jobs-dsl plugin so support new feature introduced there. Also fixed several classed because of the deprecation in the job-dsl plugin (check here and above: https://github.com/jenkinsci/job-dsl-plugin/wiki/Migration#migrating-to-154). Major changes:
- Bumped version plugin to 1.67 in build.gradle
- Removed MapJobManagement obsolete methods, added the required one
- Fixed ScriptRequest constructors, removed deprecated location parameter
- Added required name argument to the job and view factory
- Removed class="vector" from the triggers xml tag
- Removed name setter tests cause this property is readonly
You can view, comment on, or merge this pull request online at:
https://github.com/ghale/gradle-jenkins-plugin/pull/90 Commit Summary
- Bump jobdsl plugin to 1.67
File Changes
- M build.gradle https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-0 (2)
- M src/main/groovy/com/terrafolio/gradle/plugins/jenkins/dsl/JenkinsConfiguration.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-1 (2)
- M src/main/groovy/com/terrafolio/gradle/plugins/jenkins/dsl/JobDSLSupport.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-2 (4)
- M src/main/groovy/com/terrafolio/gradle/plugins/jenkins/dsl/ViewDSLSupport.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-3 (4)
- M src/main/groovy/com/terrafolio/gradle/plugins/jenkins/jobdsl/DSLJobFactory.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-4 (2)
- M src/main/groovy/com/terrafolio/gradle/plugins/jenkins/jobdsl/DSLViewFactory.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-5 (4)
- M src/main/groovy/com/terrafolio/gradle/plugins/jenkins/jobdsl/DefaultDSLJobFactory.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-6 (4)
- M src/main/groovy/com/terrafolio/gradle/plugins/jenkins/jobdsl/DefaultDSLViewFactory.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-7 (4)
- M src/main/groovy/com/terrafolio/gradle/plugins/jenkins/jobdsl/MapJobManagement.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-8 (17)
- M src/test/groovy/com/terrafolio/gradle/plugins/jenkins/test/dsl/JenkinsConfigurationTest.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-9 (2)
- M src/test/groovy/com/terrafolio/gradle/plugins/jenkins/test/dsl/JobDSLSupportTest.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-10 (20)
- M src/test/groovy/com/terrafolio/gradle/plugins/jenkins/test/dsl/JobFixtures.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-11 (8)
- M src/test/groovy/com/terrafolio/gradle/plugins/jenkins/test/dsl/ViewDSLSupportTest.groovy https://github.com/ghale/gradle-jenkins-plugin/pull/90/files#diff-12 (21)
Patch Links:
- https://github.com/ghale/gradle-jenkins-plugin/pull/90.patch
- https://github.com/ghale/gradle-jenkins-plugin/pull/90.diff
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ghale/gradle-jenkins-plugin/pull/90, or mute the thread https://github.com/notifications/unsubscribe-auth/AF8lL064AB1BkDIMUT5RXjuBZAfI-9X3ks5vLZE5gaJpZM4awE-- .
Bump version of the jobs-dsl plugin so support new feature introduced there. Also fixed several classed because of the deprecation in the job-dsl plugin (check here and above: https://github.com/jenkinsci/job-dsl-plugin/wiki/Migration#migrating-to-154). Major changes: